You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/23 18:01:49 UTC
[GitHub] [arrow-rs] viirya opened a new pull request, #1731: Fix schema comparison for non_canonical_map when running flight test
viirya opened a new pull request, #1731:
URL: https://github.com/apache/arrow-rs/pull/1731
# Which issue does this PR close?
<!---
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #1730.
# Rationale for this change
<!---
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!---
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!---
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #1731: Fix schema comparison for non_canonical_map when running flight test
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #1731:
URL: https://github.com/apache/arrow-rs/pull/1731#discussion_r879744316
##########
integration-testing/src/flight_client_scenarios/integration_test.rs:
##########
@@ -215,7 +215,7 @@ async fn consume_flight_location(
flight_data_to_arrow_batch(&data, actual_schema.clone(), &dictionaries_by_id)
.expect("Unable to convert flight data to Arrow batch");
- assert_eq!(expected_batch.schema(), actual_batch.schema());
+ assert_eq!(actual_schema, actual_batch.schema());
Review Comment:
`expected_batch`'s schema is uploaded one. The flight server could make cosmetic change (e.g., from non canonical map to canonical one) to the schema.
`actual_schema` is received from flight. We should take it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya merged pull request #1731: Fix schema comparison for non_canonical_map when running flight test
Posted by GitBox <gi...@apache.org>.
viirya merged PR #1731:
URL: https://github.com/apache/arrow-rs/pull/1731
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on pull request #1731: Fix schema comparison for non_canonical_map when running flight test
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #1731:
URL: https://github.com/apache/arrow-rs/pull/1731#issuecomment-1135162614
Thanks @tustvold. Merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #1731: Fix schema comparison for non_canonical_map when running flight test
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #1731:
URL: https://github.com/apache/arrow-rs/pull/1731#discussion_r879744316
##########
integration-testing/src/flight_client_scenarios/integration_test.rs:
##########
@@ -215,7 +215,7 @@ async fn consume_flight_location(
flight_data_to_arrow_batch(&data, actual_schema.clone(), &dictionaries_by_id)
.expect("Unable to convert flight data to Arrow batch");
- assert_eq!(expected_batch.schema(), actual_batch.schema());
+ assert_eq!(actual_schema, actual_batch.schema());
Review Comment:
`expected_batch`'s schema is uploaded one. The flight server could make cosmetic change to the schema.
`actual_schema` is received from flight. We should take it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org