You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "vanshaj2023 (via GitHub)" <gi...@apache.org> on 2026/03/13 09:21:27 UTC
[PR] fix(i18n): add missing services.empty translation key in zh, de, es, … [apisix-dashboard]
vanshaj2023 opened a new pull request, #3325:
URL: https://github.com/apache/apisix-dashboard/pull/3325
gh pr create \
--title "fix(i18n): add missing services.empty translation key in zh, de, es, and tr locales" \
--body "$(cat <<'EOF'
**Why submit this pull request?**
- [x] Bugfix
**What changes will this PR take into?**
Added missing `services.empty` translation key to the following locale files:
- `src/locales/zh/common.json`
- `src/locales/de/common.json`
- `src/locales/es/common.json`
- `src/locales/tr/common.json`
Without this key, the empty state message on the Services list page was not being translated in these languages, causing a missing/broken UI string.
**Related issues**
fix #3321
**Checklist:**
- [x] Did you explain what problem does this PR solve? Or what new features have been added?
- [ ] Have you added corresponding test cases?
- [ ] Have you modified the corresponding document?
- [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
EOF
)" \
--base master \
--head fix/i18n-services-empty-translation \
--repo apache/apisix-dashboard
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(i18n): add missing services.empty translation key in zh, de, es, … [apisix-dashboard]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #3325:
URL: https://github.com/apache/apisix-dashboard/pull/3325#discussion_r2942086400
##########
src/locales/tr/common.json:
##########
@@ -329,7 +329,8 @@
"singular": "Secret"
},
"services": {
- "singular": "Service"
+ "singular": "Service",
+ "empty": "Hizmet bulunamadı. İlk hizmetinizi oluşturmak için Service Ekle'ye tıklayın."
Review Comment:
In this locale file the Service entity is consistently referred to as "Service"/"Service'ler" (e.g., `services.singular` and `sources.services`), but this new empty-state string starts with "Hizmet". Consider using the same term as the rest of the Turkish locale for consistency and to avoid confusing users (e.g., align the first sentence with "Service").
##########
src/locales/zh/common.json:
##########
@@ -329,7 +329,8 @@
"singular": "Secret"
},
"services": {
- "singular": "服务"
+ "singular": "服务",
+ "empty": "未找到服务。创建您的第一个服务。"
Review Comment:
The English `services.empty` message includes a clear call-to-action (click “Add Service”). The Chinese translation added here omits that CTA, which makes the empty state less actionable and inconsistent with the other locales updated in this PR. Consider including the equivalent of “点击添加服务…” (or whatever the UI label is) for parity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(i18n): add missing services.empty translation key in zh, de, es, … [apisix-dashboard]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #3325:
URL: https://github.com/apache/apisix-dashboard/pull/3325#discussion_r2939546377
##########
src/locales/tr/common.json:
##########
@@ -329,7 +329,8 @@
"singular": "Secret"
},
"services": {
- "singular": "Service"
+ "singular": "Service",
+ "empty": "Hizmet bulunamadı. İlk hizmetinizi oluşturmak için Hizmet Ekle'ye tıklayın."
Review Comment:
This empty-state message tells users to click "Hizmet Ekle", but in this locale the Add button label is generated from `info.add.title` ("{{name}} Ekle") and `services.singular` ("Service"), which will render as "Service Ekle". Please align the wording here with the actual UI label to avoid confusing users.
##########
src/locales/zh/common.json:
##########
@@ -329,7 +329,8 @@
"singular": "Secret"
},
"services": {
- "singular": "服务"
+ "singular": "服务",
+ "empty": "未找到服务。点击添加服务以创建您的第一个服务。"
Review Comment:
Minor consistency: the Add button label in this locale is generated from `info.add.title` ("添加 {{name}}") and `services.singular` ("服务"), which will render with a space ("添加 服务"). This new empty-state text uses "添加服务" without a space. Consider matching the exact UI label text (or adjusting `info.add.title`) so the call-to-action matches what users see.
##########
src/locales/es/common.json:
##########
@@ -329,7 +329,8 @@
"singular": "Secreto"
},
"services": {
- "singular": "Servicio"
+ "singular": "Servicio",
+ "empty": "No se encontraron servicios. Haga clic en Agregar servicio para crear el primero."
Review Comment:
The empty-state text references an "Add service" action, but here it uses "Agregar servicio" while the actual button label in this locale comes from `info.add.title` ("Añadir {{name}}" → "Añadir Servicio"). Consider updating this string to match the UI label wording so users can find the correct action easily.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(i18n): add missing services.empty translation key in zh, de, es, … [apisix-dashboard]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #3325:
URL: https://github.com/apache/apisix-dashboard/pull/3325#discussion_r2942101758
##########
src/locales/es/common.json:
##########
@@ -329,7 +329,8 @@
"singular": "Secreto"
},
"services": {
- "singular": "Servicio"
+ "singular": "Servicio",
+ "empty": "No se encontraron servicios. Haga clic en Añadir Servicio para crear el primero."
Review Comment:
This string hard-codes the action label (“Añadir Servicio”), but the UI constructs that label via `info.add.title` + `services.singular`. That means any future change to the add-action translation will require updating this message too. Prefer wording that doesn’t reference the exact button text, or change the UI to interpolate the computed label into `services.empty`.
##########
src/locales/tr/common.json:
##########
@@ -329,7 +329,8 @@
"singular": "Secret"
},
"services": {
- "singular": "Service"
+ "singular": "Service",
+ "empty": "Service bulunamadı. İlk Service'inizi oluşturmak için Service Ekle'ye tıklayın."
Review Comment:
The empty-state message includes the literal action label (“Service Ekle”), but the UI generates that label from `info.add.title` + `services.singular`. This duplicates translation concerns and may become inconsistent if the button text changes. Consider avoiding the explicit button label in this message, or have the UI interpolate the computed label into `services.empty`.
##########
src/locales/de/common.json:
##########
@@ -329,7 +329,8 @@
"singular": "Secret"
},
"services": {
- "singular": "Service"
+ "singular": "Service",
+ "empty": "Keine Services gefunden. Klicken Sie auf Service hinzufügen, um Ihren ersten zu erstellen."
Review Comment:
The translated empty-state text hard-codes the current button label (“Service hinzufügen”). Since the actual button label is produced via i18n (`t('info.add.title', { name: t('services.singular') })`), this couples two separate translations and will drift if the action text changes. Consider rewording to avoid naming the button, or update the UI to pass the computed label as an interpolation variable for `services.empty`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(i18n): add missing services.empty translation key in zh, de, es, … [apisix-dashboard]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #3325:
URL: https://github.com/apache/apisix-dashboard/pull/3325#discussion_r2942069874
##########
src/locales/zh/common.json:
##########
@@ -329,7 +329,8 @@
"singular": "Secret"
},
"services": {
- "singular": "服务"
+ "singular": "服务",
+ "empty": "未找到服务。点击添加服务以创建您的第一个服务。"
Review Comment:
The new `services.empty` string references the Add button label (“点击添加服务…”), but this locale’s `info.add.title` is `"添加 {{name}}"` (likely rendering as “添加 服务” for services). This may make the instruction not match the actual button text; consider aligning the phrasing with `info.add.title` (or avoiding referring to the exact label).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(i18n): add missing services.empty translation key in zh, de, es, … [apisix-dashboard]
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop merged PR #3325:
URL: https://github.com/apache/apisix-dashboard/pull/3325
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org