You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nifi.apache.org by sc...@apache.org on 2018/04/30 19:01:37 UTC
[12/19] nifi-fds git commit: [NIFIREG-168] add package-lock.json,
update version number to indicate current version,
update pr template to simplify reviewer process
[NIFIREG-168] add package-lock.json, update version number to indicate current version, update pr template to simplify reviewer process
Project: http://git-wip-us.apache.org/repos/asf/nifi-fds/repo
Commit: http://git-wip-us.apache.org/repos/asf/nifi-fds/commit/544c0e4a
Tree: http://git-wip-us.apache.org/repos/asf/nifi-fds/tree/544c0e4a
Diff: http://git-wip-us.apache.org/repos/asf/nifi-fds/diff/544c0e4a
Branch: refs/heads/gh-pages
Commit: 544c0e4a192d9a421bea3c3aeec40591e6cf17a8
Parents: fd57eb4
Author: Scott Aslan <sc...@gmail.com>
Authored: Wed Apr 25 15:49:47 2018 -0400
Committer: Scott Aslan <sc...@gmail.com>
Committed: Wed Apr 25 15:49:47 2018 -0400
----------------------------------------------------------------------
.github/PULL_REQUEST_TEMPLATE.md | 10 +-
package-lock.json | 5757 +++++++++++++++++++++++++++++++++
package.json | 2 +-
3 files changed, 5762 insertions(+), 7 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/nifi-fds/blob/544c0e4a/.github/PULL_REQUEST_TEMPLATE.md
----------------------------------------------------------------------
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index 337e726..cb9093a 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -30,9 +30,7 @@ Please ensure that once the PR is submitted, you check travis-ci for build issue
### Reviewers, please perform the following in order to validate the changes:
- [ ] Checkout the gh-pages branch.
-- [ ] Edit the package.json file in the root nifi-fds folder and update the nifi-fds package in the dependencies section to point to the pull request at git+https://github.com/user/repo.git#branch.
-- [ ] ‘npm install’ in the root nifi-fds folder.
-- [ ] ‘npm install’ in the node_modules/nifi-fds folder.
-- [ ] ‘npm run build’ in the node_modules/nifi-fds folder.
-- [ ] Update the base href element in the index.html in the root nifi-fds folder to ‘/‘.
-- [ ] Start a local http-server via ‘npm start’ in the root nifi-fds folder and verify the UI/UX in a browser.
+- [ ] Open the package.json file in the root nifi-fds folder and in the dependencies property edit the nifi-fds module to point to the pull request under review by replacing the user name, repository name, and branch name to the appropriate values for the PR.
+ Ex. To point to the Apache NiFi FDS master branch replace the user, repository, and branch name in the string git+https://github.com/USER_NAME/REPO_NAME.git#PR_BRANCH_NAME to:
+ "nifi-fds": "git+https://github.com/apache/nifi-fds.git#master"
+- [ ] ‘npm start’ in the root nifi-fds folder and verify the UI/UX in a browser.