You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/08 18:07:49 UTC

[GitHub] [airflow] iAnomaly edited a comment on pull request #19389: env: Add support for different value keys

iAnomaly edited a comment on pull request #19389:
URL: https://github.com/apache/airflow/pull/19389#issuecomment-963424457


   > What is the difference between the .env field and the .extraEnv field?
   > 
   > https://github.com/apache/airflow/blob/91c53cc102ee2eef6bd4bc872cea361ac3569781/chart/templates/_helpers.yaml#L121-L123
   
   I guess I can use that instead but there are differences:
   1. `tpl` function expects a string so you have to do:
   ```
   extraEnv: |
       - name: AIRFLOW__SCHEDULER__STATSD_HOST
         valueFrom:
           fieldRef:
             fieldPath: status.hostIP
   ```
   instead of:
   ```
   env:
     - name: AIRFLOW__SCHEDULER__STATSD_HOST
       valueFrom:
         fieldRef:
           fieldPath: status.hostIP
   ```
   
   2. You don't get the automatic creation of `AIRFLOW__KUBERNETES_ENVIRONMENT_VARIABLES__{{ .name }}` for free (obviously that could also be added as another list entry for extraEnv)
   
   I will close this PR if there is no added value here/`extraEnv` is the preferred way to go.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org