[GitHub] [druid] bananaaggle commented on pull request #11377: Add Environment Variable DynamicConfigProvider

[GitBox <gi...@apache.org>]

bananaaggle commented on pull request #11377:
URL: https://github.com/apache/druid/pull/11377#issuecomment-871093069


   > @bananaaggle thanks for the quick response. The code change LGTM, but there are 2 things missing here, one is documentation and another is tests. For documentation, I think you can add some in `docs/operations/dynamic-config-provider.md`. For tests, you can add some unit tests in `EnvironmentVariableDynamicConfigProviderTest` that should run with a proper set of environment variables. To let Travis CI run those new tests successfully, you will need to add those environment variables in `.travis.yaml` too. I can help you with adding these, let me know if you have questions.
   
   Document added. I'll add more tests in week.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org