You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/04/09 07:14:48 UTC

[GitHub] [couchdb-documentation] bessbd opened a new pull request #519: Remove unnecessary items from the PR checklist

bessbd opened a new pull request #519: Remove unnecessary items from the PR checklist
URL: https://github.com/apache/couchdb-documentation/pull/519
 
 
   The checklist includes items about writing documentation and running automated tests.
   
   The first item is not applicable as most of the commits in this repo are supposed to be doc changes and the automated tests are run for every PR via the Jenkins CI so it's redundant to have a checkbox in the PR summary.
   
   This change removes those two non-applicable items.
   
   <!-- Thank you for your contribution!
   
        Please file this form by replacing the Markdown comments
        with your text. If a section needs no action - remove it.
   
        Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
        of code collaboration. Positive feedback is represented +1 from committers
        and negative is a -1. The -1 also means veto, and needs to be addressed
        to proceed. Once there are no objections, the PR can be merged by a
        CouchDB committer.
   
        See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
   
   ## Overview
   
   <!-- Please give a short brief for the pull request,
        what problem it solves or how it makes things better. -->
   
   ## Testing recommendations
   
   <!-- Describe how we can test your changes.
        Does it provides any behaviour that the end users
        could notice? -->
   
   ## GitHub issue number
   
   <!-- If this is a significant change, please file a separate issue at:
        https://github.com/apache/couchdb-documentation/issues
        and include the number here and in commit message(s) using
        syntax like "Fixes #472" or "Fixes apache/couchdb#472".  -->
   
   ## Related Pull Requests
   
   <!-- If your changes affects multiple components in different
        repositories please put links to those pull requests here.  -->
   
   ## Checklist
   
   - [ ] Documentation is written and is accurate;
   - [ ] `make check` passes with no errors
   - [ ] Update [rebar.config.script](https://github.com/apache/couchdb/blob/master/rebar.config.script) with the commit hash once this PR is rebased and merged
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [couchdb-documentation] janl commented on issue #519: Remove unnecessary items from the PR checklist

Posted by GitBox <gi...@apache.org>.
janl commented on issue #519: Remove unnecessary items from the PR checklist
URL: https://github.com/apache/couchdb-documentation/pull/519#issuecomment-611449091
 
 
   `make check` passes is useful to ensure that you don’t accidentally commit a syntax error. You would likely want a faster turnaround time on those than a CI build. So we recommend you run `make check` locally before opening a PR. Hence the checkbox.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [couchdb-documentation] janl commented on issue #519: Remove unnecessary items from the PR checklist

Posted by GitBox <gi...@apache.org>.
janl commented on issue #519: Remove unnecessary items from the PR checklist
URL: https://github.com/apache/couchdb-documentation/pull/519#issuecomment-613326013
 
 
   sounds good to me!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [couchdb-documentation] bessbd commented on issue #519: Remove unnecessary items from the PR checklist

Posted by GitBox <gi...@apache.org>.
bessbd commented on issue #519: Remove unnecessary items from the PR checklist
URL: https://github.com/apache/couchdb-documentation/pull/519#issuecomment-614448635
 
 
   > sounds good to me!
   
   I've added the comment, @janl . Let me know what you think.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [couchdb-documentation] bessbd commented on issue #519: Remove unnecessary items from the PR checklist

Posted by GitBox <gi...@apache.org>.
bessbd commented on issue #519: Remove unnecessary items from the PR checklist
URL: https://github.com/apache/couchdb-documentation/pull/519#issuecomment-611454848
 
 
   > `make check` passes is useful to ensure that you don’t accidentally commit a syntax error. You would likely want a faster turnaround time on those than a CI build. So we recommend you run `make check` locally before opening a PR. Hence the checkbox.
   
   What do you think about adding a md-comment notice then? Eg. 
   ```
   <!-- Before opening the PR, consider running `make check` locally for a faster turnaround time -->
   ```
   ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [couchdb-documentation] nickva commented on a change in pull request #519: Remove unnecessary items from the PR checklist

Posted by GitBox <gi...@apache.org>.
nickva commented on a change in pull request #519: Remove unnecessary items from the PR checklist
URL: https://github.com/apache/couchdb-documentation/pull/519#discussion_r406301502
 
 

 ##########
 File path: .github/PULL_REQUEST_TEMPLATE.md
 ##########
 @@ -36,6 +36,4 @@
 
 ## Checklist
 
-- [ ] Documentation is written and is accurate;
-- [ ] `make check` passes with no errors
 
 Review comment:
   Let's keep `make check` it runs the linter to check formatting and such

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [couchdb-documentation] nickva commented on a change in pull request #519: Remove unnecessary items from the PR checklist

Posted by GitBox <gi...@apache.org>.
nickva commented on a change in pull request #519: Remove unnecessary items from the PR checklist
URL: https://github.com/apache/couchdb-documentation/pull/519#discussion_r406301502
 
 

 ##########
 File path: .github/PULL_REQUEST_TEMPLATE.md
 ##########
 @@ -36,6 +36,4 @@
 
 ## Checklist
 
-- [ ] Documentation is written and is accurate;
-- [ ] `make check` passes with no errors
 
 Review comment:
   Let's keep `make check` it runs the linter to check formatting and such

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services