You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@openoffice.apache.org by hd...@apache.org on 2013/05/16 09:25:50 UTC
svn commit: r1483216 - /openoffice/trunk/main/sal/inc/rtl/string.hxx
Author: hdu
Date: Thu May 16 07:25:49 2013
New Revision: 1483216
URL: http://svn.apache.org/r1483216
Log:
fix constness issue causing a build breaker
Modified:
openoffice/trunk/main/sal/inc/rtl/string.hxx
Modified: openoffice/trunk/main/sal/inc/rtl/string.hxx
URL: http://svn.apache.org/viewvc/openoffice/trunk/main/sal/inc/rtl/string.hxx?rev=1483216&r1=1483215&r2=1483216&view=diff
==============================================================================
--- openoffice/trunk/main/sal/inc/rtl/string.hxx (original)
+++ openoffice/trunk/main/sal/inc/rtl/string.hxx Thu May 16 07:25:49 2013
@@ -947,7 +947,7 @@ struct CStringHash
size_t operator()( const char* p) const {
size_t n = 0;
while( *p)
- n += 4*n + *static_cast<unsigned char*>(p++);
+ n += 4*n + *static_cast<const unsigned char*>(p++);
return n;
}
};
Re: svn commit: r1483216 - /openoffice/trunk/main/sal/inc/rtl/string.hxx
Posted by Herbert Dürr <hd...@apache.org>.
On 2013/05/16 4:08 PM, Ariel Constenla-Haile wrote:
> On Thu, May 16, 2013 at 09:03:26AM -0500, jorge ivan poot diaz wrote:
>> Hello Ariel,
>>
>> In my local directory:
>> size_t operator()( const char* p) const {
>> size_t n = 0;
>> while( *p)
>> n += 4*n + *static_cast<unsigned char*>(p++);
>> return n;
>
> Update your local copy, Herbert fixed this already.
Yup. Sorry again. It worked on my current main system which defaults to
unsigned chars...
Herbert
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: svn commit: r1483216 -
/openoffice/trunk/main/sal/inc/rtl/string.hxx
Posted by Ariel Constenla-Haile <ar...@apache.org>.
On Thu, May 16, 2013 at 09:03:26AM -0500, jorge ivan poot diaz wrote:
> Hello Ariel,
>
> In my local directory:
> size_t operator()( const char* p) const {
> size_t n = 0;
> while( *p)
> n += 4*n + *static_cast<unsigned char*>(p++);
> return n;
Update your local copy, Herbert fixed this already.
Regards
--
Ariel Constenla-Haile
La Plata, Argentina
Re: svn commit: r1483216 - /openoffice/trunk/main/sal/inc/rtl/string.hxx
Posted by jorge ivan poot diaz <iv...@gmail.com>.
Hello Ariel,
In my local directory:
size_t operator()( const char* p) const {
size_t n = 0;
while( *p)
n += 4*n + *static_cast<unsigned char*>(p++);
return n;
I have already made the change, but the error persists.
(pastebin, do not open the page)
but here is the error:
http://imagebin.org/257829
2013/5/16 Ariel Constenla-Haile <ar...@apache.org>
> On Thu, May 16, 2013 at 4:25 AM, <hd...@apache.org> wrote:
> > Author: hdu
> > Date: Thu May 16 07:25:49 2013
> > New Revision: 1483216
> >
> > URL: http://svn.apache.org/r1483216
> > Log:
> > fix constness issue causing a build breaker
> >
> > Modified:
> > openoffice/trunk/main/sal/inc/rtl/string.hxx
> >
> > Modified: openoffice/trunk/main/sal/inc/rtl/string.hxx
> > URL:
> http://svn.apache.org/viewvc/openoffice/trunk/main/sal/inc/rtl/string.hxx?rev=1483216&r1=1483215&r2=1483216&view=diff
> >
> ==============================================================================
> > --- openoffice/trunk/main/sal/inc/rtl/string.hxx (original)
> > +++ openoffice/trunk/main/sal/inc/rtl/string.hxx Thu May 16 07:25:49 2013
> > @@ -947,7 +947,7 @@ struct CStringHash
> > size_t operator()( const char* p) const {
> > size_t n = 0;
> > while( *p)
> > - n += 4*n + *static_cast<unsigned char*>(p++);
> > + n += 4*n + *static_cast<const unsigned
> char*>(p++);
>
> This still breaks:
> ./../inc/rtl/string.hxx:950:53: error: invalid static_cast from type
> 'const char*' to type 'const unsigned char*'
>
> Regards
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
> For additional commands, e-mail: dev-help@openoffice.apache.org
>
>
Re: svn commit: r1483216 - /openoffice/trunk/main/sal/inc/rtl/string.hxx
Posted by Ariel Constenla-Haile <ar...@apache.org>.
On Thu, May 16, 2013 at 4:25 AM, <hd...@apache.org> wrote:
> Author: hdu
> Date: Thu May 16 07:25:49 2013
> New Revision: 1483216
>
> URL: http://svn.apache.org/r1483216
> Log:
> fix constness issue causing a build breaker
>
> Modified:
> openoffice/trunk/main/sal/inc/rtl/string.hxx
>
> Modified: openoffice/trunk/main/sal/inc/rtl/string.hxx
> URL: http://svn.apache.org/viewvc/openoffice/trunk/main/sal/inc/rtl/string.hxx?rev=1483216&r1=1483215&r2=1483216&view=diff
> ==============================================================================
> --- openoffice/trunk/main/sal/inc/rtl/string.hxx (original)
> +++ openoffice/trunk/main/sal/inc/rtl/string.hxx Thu May 16 07:25:49 2013
> @@ -947,7 +947,7 @@ struct CStringHash
> size_t operator()( const char* p) const {
> size_t n = 0;
> while( *p)
> - n += 4*n + *static_cast<unsigned char*>(p++);
> + n += 4*n + *static_cast<const unsigned char*>(p++);
This still breaks:
./../inc/rtl/string.hxx:950:53: error: invalid static_cast from type
'const char*' to type 'const unsigned char*'
Regards
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org