[jira] [Commented] (STORM-3822) Colon in streamId breaks topology visualization

["Ben Roling (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-3822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17490502#comment-17490502 ] 

Ben Roling commented on STORM-3822:
-----------------------------------

PR:
https://github.com/apache/storm/pull/3441

> Colon in streamId breaks topology visualization
> -----------------------------------------------
>
>                 Key: STORM-3822
>                 URL: https://issues.apache.org/jira/browse/STORM-3822
>             Project: Apache Storm
>          Issue Type: Bug
>          Components: storm-webapp
>    Affects Versions: 2.3.1
>            Reporter: Ben Roling
>            Priority: Major
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> If a streamId contains a colon (":"), the Topology Visualization will be empty in the storm UI.
> The cause is a JavaScript error like the following (captured from storm-2.2.0 though the issue looks like it wouldn't be resolved in 2.3.1).  The last bit after "unsupported pseudo" depends on the actual streamId.  In the case that generated this, the streamId was "my:stream".
> {code}
> Uncaught Error: Syntax error, unrecognized expression: unsupported pseudo: stream
>     at Function.fb.error (jquery-1.11.1.min.js:2:12720)
>     at PSEUDO (jquery-1.11.1.min.js:2:15641)
>     at wb (jquery-1.11.1.min.js:2:20274)
>     at fb.compile (jquery-1.11.1.min.js:2:21173)
>     at fb.select (jquery-1.11.1.min.js:2:21853)
>     at Function.fb [as find] (jquery-1.11.1.min.js:2:7352)
>     at m.fn.init.find (jquery-1.11.1.min.js:2:23595)
>     at String.<anonymous> (visualization.js:288:39)
>     at Function.each (jquery-1.11.1.min.js:2:3027)
>     at updateAvailableStreams (visualization.js:287:7)
> {code}
> It looks like UIHelpers.sanitizeStreamName(String streamName) is intended to replace some characters (that presumably would break the visualization) with underscore ("_").  However, it allows the colons through even though they also break the visualization.  It seems an easy fix might be to adjust that method so that it also replaces colons with underscores.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)