You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/11/15 15:26:33 UTC
[GitHub] [hudi] codope opened a new pull request #4002: [HUDI-2743] Remove fs.exists() in AbstractTableFileSystemView
codope opened a new pull request #4002:
URL: https://github.com/apache/hudi/pull/4002
## What is the purpose of the pull request
This PR removes the unnecessary `fs.exist()` while listing partition. It is expected that the partition path will exist, if not an exception will be thrown. This saves some time during listing.
## Verify this pull request
This pull request is already covered by existing tests, and added a small UT to assert exception.
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4002: [HUDI-2743] Assume path exists and defer fs.exists() in AbstractTableFileSystemView
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4002:
URL: https://github.com/apache/hudi/pull/4002#issuecomment-975343268
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0296a7541a161c4bc76aba0013f6b2fc75758e24",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3381",
"triggerID" : "0296a7541a161c4bc76aba0013f6b2fc75758e24",
"triggerType" : "PUSH"
}, {
"hash" : "bd9cf565818e370b75b9e352abdcbbde701a9d89",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bd9cf565818e370b75b9e352abdcbbde701a9d89",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0296a7541a161c4bc76aba0013f6b2fc75758e24 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3381)
* bd9cf565818e370b75b9e352abdcbbde701a9d89 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4002: [HUDI-2743] Remove fs.exists() in AbstractTableFileSystemView
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4002:
URL: https://github.com/apache/hudi/pull/4002#issuecomment-969026308
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0296a7541a161c4bc76aba0013f6b2fc75758e24",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0296a7541a161c4bc76aba0013f6b2fc75758e24",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0296a7541a161c4bc76aba0013f6b2fc75758e24 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4002: [HUDI-2743] Assume path exists and defer fs.exists() in AbstractTableFileSystemView
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4002:
URL: https://github.com/apache/hudi/pull/4002#issuecomment-975343268
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0296a7541a161c4bc76aba0013f6b2fc75758e24",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3381",
"triggerID" : "0296a7541a161c4bc76aba0013f6b2fc75758e24",
"triggerType" : "PUSH"
}, {
"hash" : "bd9cf565818e370b75b9e352abdcbbde701a9d89",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bd9cf565818e370b75b9e352abdcbbde701a9d89",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0296a7541a161c4bc76aba0013f6b2fc75758e24 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3381)
* bd9cf565818e370b75b9e352abdcbbde701a9d89 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4002: [HUDI-2743] Remove fs.exists() in AbstractTableFileSystemView
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4002:
URL: https://github.com/apache/hudi/pull/4002#issuecomment-969029112
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0296a7541a161c4bc76aba0013f6b2fc75758e24",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3381",
"triggerID" : "0296a7541a161c4bc76aba0013f6b2fc75758e24",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0296a7541a161c4bc76aba0013f6b2fc75758e24 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3381)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan merged pull request #4002: [HUDI-2743] Assume path exists and defer fs.exists() in AbstractTableFileSystemView
Posted by GitBox <gi...@apache.org>.
nsivabalan merged pull request #4002:
URL: https://github.com/apache/hudi/pull/4002
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4002: [HUDI-2743] Assume path exists and defer fs.exists() in AbstractTableFileSystemView
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4002:
URL: https://github.com/apache/hudi/pull/4002#issuecomment-969101162
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0296a7541a161c4bc76aba0013f6b2fc75758e24",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3381",
"triggerID" : "0296a7541a161c4bc76aba0013f6b2fc75758e24",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0296a7541a161c4bc76aba0013f6b2fc75758e24 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3381)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4002: [HUDI-2743] Assume path exists and defer fs.exists() in AbstractTableFileSystemView
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4002:
URL: https://github.com/apache/hudi/pull/4002#issuecomment-975345811
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0296a7541a161c4bc76aba0013f6b2fc75758e24",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3381",
"triggerID" : "0296a7541a161c4bc76aba0013f6b2fc75758e24",
"triggerType" : "PUSH"
}, {
"hash" : "bd9cf565818e370b75b9e352abdcbbde701a9d89",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3575",
"triggerID" : "bd9cf565818e370b75b9e352abdcbbde701a9d89",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0296a7541a161c4bc76aba0013f6b2fc75758e24 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3381)
* bd9cf565818e370b75b9e352abdcbbde701a9d89 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3575)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4002: [HUDI-2743] Remove fs.exists() in AbstractTableFileSystemView
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4002:
URL: https://github.com/apache/hudi/pull/4002#issuecomment-969026308
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0296a7541a161c4bc76aba0013f6b2fc75758e24",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0296a7541a161c4bc76aba0013f6b2fc75758e24",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0296a7541a161c4bc76aba0013f6b2fc75758e24 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4002: [HUDI-2743][WIP] Remove fs.exists() in AbstractTableFileSystemView
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4002:
URL: https://github.com/apache/hudi/pull/4002#issuecomment-969029112
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0296a7541a161c4bc76aba0013f6b2fc75758e24",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3381",
"triggerID" : "0296a7541a161c4bc76aba0013f6b2fc75758e24",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0296a7541a161c4bc76aba0013f6b2fc75758e24 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3381)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4002: [HUDI-2743][WIP] Remove fs.exists() in AbstractTableFileSystemView
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4002:
URL: https://github.com/apache/hudi/pull/4002#issuecomment-969101162
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0296a7541a161c4bc76aba0013f6b2fc75758e24",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3381",
"triggerID" : "0296a7541a161c4bc76aba0013f6b2fc75758e24",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0296a7541a161c4bc76aba0013f6b2fc75758e24 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3381)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #4002: [HUDI-2743][WIP] Remove fs.exists() in AbstractTableFileSystemView
Posted by GitBox <gi...@apache.org>.
danny0405 commented on pull request #4002:
URL: https://github.com/apache/hudi/pull/4002#issuecomment-971257082
Hi, @codope, do we want this patch into release 0.10.0 ? You can tag it as release-blocker if you think it is necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4002: [HUDI-2743] Assume path exists and defer fs.exists() in AbstractTableFileSystemView
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4002:
URL: https://github.com/apache/hudi/pull/4002#issuecomment-975345811
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0296a7541a161c4bc76aba0013f6b2fc75758e24",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3381",
"triggerID" : "0296a7541a161c4bc76aba0013f6b2fc75758e24",
"triggerType" : "PUSH"
}, {
"hash" : "bd9cf565818e370b75b9e352abdcbbde701a9d89",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3575",
"triggerID" : "bd9cf565818e370b75b9e352abdcbbde701a9d89",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0296a7541a161c4bc76aba0013f6b2fc75758e24 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3381)
* bd9cf565818e370b75b9e352abdcbbde701a9d89 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3575)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4002: [HUDI-2743] Assume path exists and defer fs.exists() in AbstractTableFileSystemView
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4002:
URL: https://github.com/apache/hudi/pull/4002#issuecomment-975408638
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0296a7541a161c4bc76aba0013f6b2fc75758e24",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3381",
"triggerID" : "0296a7541a161c4bc76aba0013f6b2fc75758e24",
"triggerType" : "PUSH"
}, {
"hash" : "bd9cf565818e370b75b9e352abdcbbde701a9d89",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3575",
"triggerID" : "bd9cf565818e370b75b9e352abdcbbde701a9d89",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bd9cf565818e370b75b9e352abdcbbde701a9d89 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3575)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org