You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "djanderson (via GitHub)" <gi...@apache.org> on 2024/07/27 00:23:23 UTC
[PR] Do put statement ingest [arrow-rs]
djanderson opened a new pull request, #6137:
URL: https://github.com/apache/arrow-rs/pull/6137
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes https://github.com/apache/arrow-rs/issues/6124.
Depends on https://github.com/apache/arrow-rs/pull/6133.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
This implements the handler for the new `CommandStatementIngest` message defined in [Arrow Flight SQL version 17.0](https://github.com/apache/arrow/blob/084387c56e45bf7e8335c28e14a2e61b16515ad5/format/FlightSql.proto).
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
The generated `CommandStatementIngest` from https://github.com/apache/arrow-rs/pull/6133 is exposed as a public member of the arrow_flight `sql` module and the `FlightSqlService` trait is updated with a handler for that new command.
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
Yes, the trait `FlightSqlService` has a new method, `do_put_statement_ingest`.
This PR should be tagged `api-change`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement do_put_statement_ingest handler in FlightSqlService [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6137:
URL: https://github.com/apache/arrow-rs/pull/6137#issuecomment-2262749858
BTW when you next get a chance to work on this PR, can you please change it so it targets the `master` branch rather than the `53.0.0-dev` branch? We are now making changes on main for the next release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement do_put_statement_ingest handler in FlightSqlService [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed pull request #6137: Implement do_put_statement_ingest handler in FlightSqlService
URL: https://github.com/apache/arrow-rs/pull/6137
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement do_put_statement_ingest handler in FlightSqlService [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6137:
URL: https://github.com/apache/arrow-rs/pull/6137#issuecomment-2265498629
It appears that github automatically closes the PR when the target branch is deleted -- sorry about that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement do_put_statement_ingest handler in FlightSqlService [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6137:
URL: https://github.com/apache/arrow-rs/pull/6137#issuecomment-2256968286
Marking as draft as I think this PR is no longer waiting on feedback. Please mark it as ready for review when it is ready for another look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement do_put_statement_ingest handler in FlightSqlService [arrow-rs]
Posted by "djanderson (via GitHub)" <gi...@apache.org>.
djanderson commented on PR #6137:
URL: https://github.com/apache/arrow-rs/pull/6137#issuecomment-2264417239
@alamb of course.
I'm working on it, I'll open a PR against `master` tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org