You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "icodening (via GitHub)" <gi...@apache.org> on 2023/03/11 08:58:06 UTC
[GitHub] [dubbo] icodening commented on a diff in pull request #11640: Feature/3.2 rest protocol provider
icodening commented on code in PR #11640:
URL: https://github.com/apache/dubbo/pull/11640#discussion_r1133050704
##########
dubbo-remoting/dubbo-remoting-http/src/main/java/org/apache/dubbo/remoting/http/HttpHandler.java:
##########
@@ -34,6 +32,6 @@ public interface HttpHandler {
* @throws IOException
* @throws ServletException
*/
- void handle(HttpServletRequest request, HttpServletResponse response) throws IOException, ServletException;
+ void handle(REQUEST request, RESPONSE response) throws IOException, ServletException;
Review Comment:
will throw an `java.lang.NoClassDefFoundError` if the classpath does not have `ServletException`
##########
dubbo-rpc/dubbo-rpc-rest/src/main/java/org/apache/dubbo/rpc/protocol/rest/request/RequestFacadeFactory.java:
##########
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.dubbo.rpc.protocol.rest.request;
+
+
+public class RequestFacadeFactory {
+ private final static String JakartaServlet = "jakarta.servlet.http.HttpServletRequest";
+ private final static String JavaxServlet = "javax.servlet.http.HttpServletRequest";
+ private final static String FullHttpRequest = "io.netty.handler.codec.http.FullHttpRequest";
+
+
+ public static RequestFacade createRequestFacade(Object request) {
+
+ if (tryLoad(JavaxServlet, request)) {
+
+ return new JavaxServletRequestFacade(request);
+ }
+
+ if (tryLoad(JakartaServlet, request)) {
+ return new JakartaServletRequestFacade(request);
+ }
+
+ if (tryLoad(FullHttpRequest, request)) {
+ return new NettyRequestFacade(request,null);
+ }
+
+
+
+
+
+
+ throw new RuntimeException("no compatible ServletRequestFacade and request type is " + request.getClass());
+
+ }
+
+ public static boolean tryLoad(String requestClassName, Object request) {
+
+ ClassLoader classLoader = request.getClass().getClassLoader();
+
+ try {
+ Class<?> requestClass = classLoader.loadClass(requestClassName);
+
+ return requestClass.isAssignableFrom(request.getClass());
+
+ } catch (ClassNotFoundException e) {
+ return false;
+ }
+
+ }
Review Comment:
can be replace `org.apache.dubbo.common.utils.ClassUtils#isPresent`
##########
dubbo-rpc/dubbo-rpc-rest/src/main/java/org/apache/dubbo/rpc/protocol/rest/PathAndInvokerMapper.java:
##########
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.dubbo.rpc.protocol.rest;
+
+import org.apache.dubbo.metadata.rest.PathMatcher;
+import org.apache.dubbo.metadata.rest.RestMethodMetadata;
+import org.apache.dubbo.rpc.Invoker;
+import org.apache.dubbo.rpc.protocol.rest.exception.PathNoFoundException;
+import org.apache.dubbo.rpc.protocol.rest.util.Pair;
+
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+
+public class PathAndInvokerMapper {
Review Comment:
It seems to be similar to `org.apache.dubbo.rpc.PathResolver`?
##########
dubbo-rpc/dubbo-rpc-rest/src/main/java/org/apache/dubbo/rpc/protocol/rest/DubboHttpProtocolServer.java:
##########
@@ -80,12 +93,64 @@ protected ResteasyDeployment getDeployment() {
return deployment;
}
- private class RestHandler implements HttpHandler {
+ private class RestHandler implements HttpHandler<HttpServletRequest, HttpServletResponse> {
@Override
- public void handle(HttpServletRequest request, HttpServletResponse response) throws IOException, ServletException {
+ public void handle(HttpServletRequest servletRequest, HttpServletResponse servletResponse) throws IOException, ServletException {
+
+ RequestFacade request = RequestFacadeFactory.createRequestFacade(servletRequest);
RpcContext.getServiceContext().setRemoteAddress(request.getRemoteAddr(), request.getRemotePort());
- dispatcher.service(request, response);
+// dispatcher.service(request, servletResponse);
+
+ Pair<RpcInvocation, Invoker> build = null;
+ try {
+ build = RPCInvocationBuilder.build(request, servletRequest, servletResponse);
+ } catch (PathNoFoundException e) {
+ servletResponse.setStatus(404);
+ }
+
+ Invoker invoker = build.getSecond();
Review Comment:
will throw NPE if invoke `RPCInvocationBuilder.build` error
##########
dubbo-rpc/dubbo-rpc-rest/src/main/java/org/apache/dubbo/rpc/protocol/rest/handler/NettyHttpHandler.java:
##########
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.dubbo.rpc.protocol.rest.handler;
+
+import io.netty.handler.codec.http.FullHttpRequest;
+import org.apache.dubbo.metadata.rest.media.MediaType;
+import org.apache.dubbo.remoting.http.HttpHandler;
+import org.apache.dubbo.rpc.Invoker;
+import org.apache.dubbo.rpc.Result;
+import org.apache.dubbo.rpc.RpcInvocation;
+import org.apache.dubbo.rpc.protocol.rest.RPCInvocationBuilder;
+import org.apache.dubbo.rpc.protocol.rest.constans.RestConstant;
+import org.apache.dubbo.rpc.protocol.rest.exception.PathNoFoundException;
+import org.apache.dubbo.rpc.protocol.rest.exception.mapper.ExceptionMapper;
+import org.apache.dubbo.rpc.protocol.rest.message.HttpMessageCodecManager;
+import org.apache.dubbo.rpc.protocol.rest.netty.NettyHttpResponse;
+import org.apache.dubbo.rpc.protocol.rest.request.RequestFacade;
+import org.apache.dubbo.rpc.protocol.rest.request.RequestFacadeFactory;
+import org.apache.dubbo.rpc.protocol.rest.util.HttpHeaderUtil;
+import org.apache.dubbo.rpc.protocol.rest.util.MediaTypeUtil;
+import org.apache.dubbo.rpc.protocol.rest.util.Pair;
+
+import javax.servlet.ServletException;
+import java.io.IOException;
+
+public class NettyHttpHandler implements HttpHandler<FullHttpRequest, NettyHttpResponse> {
+
+ @Override
+ public void handle(FullHttpRequest nettyHttpRequest, NettyHttpResponse nettyHttpResponse) throws IOException, ServletException {
+
+ RequestFacade request = RequestFacadeFactory.createRequestFacade(nettyHttpRequest);
+// RpcContext.getServiceContext().setRemoteAddress(request.getRemoteAddr(), request.getRemotePort());
+// dispatcher.service(request, servletResponse);
+
+ Pair<RpcInvocation, Invoker> build = null;
+ try {
+ build = RPCInvocationBuilder.build(request, nettyHttpRequest, nettyHttpResponse);
+ } catch (PathNoFoundException e) {
+ nettyHttpResponse.setStatus(404);
+ }
+
+ Invoker invoker = build.getSecond();
Review Comment:
will throw NPE if invoke `RPCInvocationBuilder.build` error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org