You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@geode.apache.org by PivotalSarge <gi...@git.apache.org> on 2016/09/26 21:12:48 UTC

[GitHub] incubator-geode issue #245: native-client-software-grant - ClientMetadata::g...

Github user PivotalSarge commented on the issue:

    https://github.com/apache/incubator-geode/pull/245
  
    From inspection of the places where ClientMetadata::getServerLocation() gets called, I do not believe that it ought to return only secondaries when tryPrimary == false. Additionally, setting serverLocation to NULL when the list of locations is empty may break assumptions by the caller. I think there should be more information about why it is needed since ClientMetadata.hpp is not a public API and more analysis into how this change it would not break the existing calls in ClientMetaService.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---