You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org> on 2008/02/03 14:13:57 UTC
[jira] Created: (MENFORCER-33) Tidy up EvaluateBeanshell rule
Tidy up EvaluateBeanshell rule
------------------------------
Key: MENFORCER-33
URL: http://jira.codehaus.org/browse/MENFORCER-33
Project: Maven 2.x Enforcer Plugin
Issue Type: Task
Components: Standard Rules
Affects Versions: 1.0-alpha-3
Reporter: Benjamin Bentmann
Assignee: Brian Fox
Priority: Trivial
Attachments: eval-beanshell.patch
The rule contains various local variables that are only used in some log statements and hence seem superfluos. If logging is the sole purpose of these lines, they should be enclosed in a block that is guarded by {{log.isDebugEnabled()}}. There is no need to slow the check or risk failures just for the fun of debug logging.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Reopened: (MENFORCER-33) Tidy up EvaluateBeanshell rule
Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MENFORCER-33?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Fox reopened MENFORCER-33:
--------------------------------
> Tidy up EvaluateBeanshell rule
> ------------------------------
>
> Key: MENFORCER-33
> URL: http://jira.codehaus.org/browse/MENFORCER-33
> Project: Maven 2.x Enforcer Plugin
> Issue Type: Task
> Components: Standard Rules
> Affects Versions: 1.0-alpha-3
> Reporter: Benjamin Bentmann
> Assignee: Brian Fox
> Priority: Trivial
> Fix For: 1.0
>
> Attachments: eval-beanshell.patch
>
>
> The rule contains various local variables that are only used in some log statements and hence seem superfluos. If logging is the sole purpose of these lines, they should be enclosed in a block that is guarded by {{log.isDebugEnabled()}}. There is no need to slow the check or risk failures just for the fun of debug logging.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MENFORCER-33) Tidy up EvaluateBeanshell rule
Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MENFORCER-33?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Fox closed MENFORCER-33.
------------------------------
Resolution: Fixed
Fix Version/s: 1.0
> Tidy up EvaluateBeanshell rule
> ------------------------------
>
> Key: MENFORCER-33
> URL: http://jira.codehaus.org/browse/MENFORCER-33
> Project: Maven 2.x Enforcer Plugin
> Issue Type: Task
> Components: Standard Rules
> Affects Versions: 1.0-alpha-3
> Reporter: Benjamin Bentmann
> Assignee: Brian Fox
> Priority: Trivial
> Fix For: 1.0
>
> Attachments: eval-beanshell.patch
>
>
> The rule contains various local variables that are only used in some log statements and hence seem superfluos. If logging is the sole purpose of these lines, they should be enclosed in a block that is guarded by {{log.isDebugEnabled()}}. There is no need to slow the check or risk failures just for the fun of debug logging.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MENFORCER-33) Tidy up EvaluateBeanshell rule
Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MENFORCER-33?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Fox closed MENFORCER-33.
------------------------------
Resolution: Fixed
patch applied, thanks
> Tidy up EvaluateBeanshell rule
> ------------------------------
>
> Key: MENFORCER-33
> URL: http://jira.codehaus.org/browse/MENFORCER-33
> Project: Maven 2.x Enforcer Plugin
> Issue Type: Task
> Components: Standard Rules
> Affects Versions: 1.0-alpha-3
> Reporter: Benjamin Bentmann
> Assignee: Brian Fox
> Priority: Trivial
> Attachments: eval-beanshell.patch
>
>
> The rule contains various local variables that are only used in some log statements and hence seem superfluos. If logging is the sole purpose of these lines, they should be enclosed in a block that is guarded by {{log.isDebugEnabled()}}. There is no need to slow the check or risk failures just for the fun of debug logging.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira