You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2024/10/23 11:10:26 UTC
[PR] HDDS-11134. Create compatibility test for FSO bucket usage [ozone]
adoroszlai opened a new pull request, #7350:
URL: https://github.com/apache/ozone/pull/7350
## What changes were proposed in this pull request?
Add coverage in `xcompat` tests for creating and using FSO bucket.
This feature was broken by the fix for HDDS-10983, but not noticed due to lack of coverage. Now that HDDS-11132 fixes the incompatibility, we can introduce test for it.
https://issues.apache.org/jira/browse/HDDS-11134
## How was this patch tested?
Verified the test fails without HDDS-11132:
https://github.com/adoroszlai/ozone/actions/runs/11474390732/job/31930860354#step:5:1056
and it passes with the fix:
https://github.com/adoroszlai/ozone/actions/runs/11473840196/job/31929094519#step:5:1058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11134. Create compatibility test for FSO bucket usage [ozone]
Posted by "ivanzlenko (via GitHub)" <gi...@apache.org>.
ivanzlenko commented on code in PR #7350:
URL: https://github.com/apache/ozone/pull/7350#discussion_r1817179621
##########
hadoop-ozone/dist/src/main/smoketest/compatibility/read.robot:
##########
@@ -37,4 +37,12 @@ Dir Can Be Listed Using Shell
File Can Be Get
Execute ozone fs -get o3fs://bucket1.vol1/dir-${SUFFIX}/file-${SUFFIX} /tmp/
Execute diff -q ${TESTFILE} /tmp/file-${SUFFIX}
- [teardown] Execute rm /tmp/file-${SUFFIX}
+ [teardown] Execute rm -f /tmp/file-${SUFFIX}
+
+FSO Bucket Can Be Read
Review Comment:
Thanks for the clarification! Will keep this in mind!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11134. Create compatibility test for FSO bucket usage [ozone]
Posted by "ivanzlenko (via GitHub)" <gi...@apache.org>.
ivanzlenko commented on code in PR #7350:
URL: https://github.com/apache/ozone/pull/7350#discussion_r1812761519
##########
hadoop-ozone/dist/src/main/smoketest/compatibility/read.robot:
##########
@@ -37,4 +37,12 @@ Dir Can Be Listed Using Shell
File Can Be Get
Execute ozone fs -get o3fs://bucket1.vol1/dir-${SUFFIX}/file-${SUFFIX} /tmp/
Execute diff -q ${TESTFILE} /tmp/file-${SUFFIX}
- [teardown] Execute rm /tmp/file-${SUFFIX}
+ [teardown] Execute rm -f /tmp/file-${SUFFIX}
+
+FSO Bucket Can Be Read
Review Comment:
It doesn't feel right that we are using this approach with relying on test results from another test here. I know it is the same for a common bucket, but could it be avoided for a new test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11134. Create compatibility test for FSO bucket usage [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #7350:
URL: https://github.com/apache/ozone/pull/7350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11134. Create compatibility test for FSO bucket usage [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #7350:
URL: https://github.com/apache/ozone/pull/7350#issuecomment-2440752032
Thanks @devabhishekpal, @ivanzlenko, @sadanand48, @tanvipenumudy for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11134. Create compatibility test for FSO bucket usage [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #7350:
URL: https://github.com/apache/ozone/pull/7350#discussion_r1817168926
##########
hadoop-ozone/dist/src/main/smoketest/compatibility/read.robot:
##########
@@ -37,4 +37,12 @@ Dir Can Be Listed Using Shell
File Can Be Get
Execute ozone fs -get o3fs://bucket1.vol1/dir-${SUFFIX}/file-${SUFFIX} /tmp/
Execute diff -q ${TESTFILE} /tmp/file-${SUFFIX}
- [teardown] Execute rm /tmp/file-${SUFFIX}
+ [teardown] Execute rm -f /tmp/file-${SUFFIX}
+
+FSO Bucket Can Be Read
Review Comment:
`read.robot` relies on the content created by `write.robot` by design, because we need to cross-check between versions. E.g. running a 2.0.0 cluster write data with both 1.4.0 and 2.0.0 clients, then verify that they can read content written by the other. This cannot be done in a single self-contained robot test, since that is run in a specific container with a specific Ozone version.
`upgrade` test is somewhat similar (write with one version, upgrade, write with new version, read both with new version).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11134. Create compatibility test for FSO bucket usage [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #7350:
URL: https://github.com/apache/ozone/pull/7350#discussion_r1816066018
##########
hadoop-ozone/dist/src/main/smoketest/compatibility/read.robot:
##########
@@ -37,4 +37,12 @@ Dir Can Be Listed Using Shell
File Can Be Get
Execute ozone fs -get o3fs://bucket1.vol1/dir-${SUFFIX}/file-${SUFFIX} /tmp/
Execute diff -q ${TESTFILE} /tmp/file-${SUFFIX}
- [teardown] Execute rm /tmp/file-${SUFFIX}
+ [teardown] Execute rm -f /tmp/file-${SUFFIX}
+
+FSO Bucket Can Be Read
Review Comment:
@ivanzlenko can you please clarify your comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11134. Create compatibility test for FSO bucket usage [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #7350:
URL: https://github.com/apache/ozone/pull/7350#discussion_r1812859578
##########
hadoop-ozone/dist/src/main/smoketest/compatibility/read.robot:
##########
@@ -37,4 +37,12 @@ Dir Can Be Listed Using Shell
File Can Be Get
Execute ozone fs -get o3fs://bucket1.vol1/dir-${SUFFIX}/file-${SUFFIX} /tmp/
Execute diff -q ${TESTFILE} /tmp/file-${SUFFIX}
- [teardown] Execute rm /tmp/file-${SUFFIX}
+ [teardown] Execute rm -f /tmp/file-${SUFFIX}
+
+FSO Bucket Can Be Read
Review Comment:
@ivanzlenko Which "another test" do you mean?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11134. Create compatibility test for FSO bucket usage [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #7350:
URL: https://github.com/apache/ozone/pull/7350#discussion_r1812859578
##########
hadoop-ozone/dist/src/main/smoketest/compatibility/read.robot:
##########
@@ -37,4 +37,12 @@ Dir Can Be Listed Using Shell
File Can Be Get
Execute ozone fs -get o3fs://bucket1.vol1/dir-${SUFFIX}/file-${SUFFIX} /tmp/
Execute diff -q ${TESTFILE} /tmp/file-${SUFFIX}
- [teardown] Execute rm /tmp/file-${SUFFIX}
+ [teardown] Execute rm -f /tmp/file-${SUFFIX}
+
+FSO Bucket Can Be Read
Review Comment:
Which "another test" do you mean?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11134. Create compatibility test for FSO bucket usage [ozone]
Posted by "ivanzlenko (via GitHub)" <gi...@apache.org>.
ivanzlenko commented on code in PR #7350:
URL: https://github.com/apache/ozone/pull/7350#discussion_r1817143002
##########
hadoop-ozone/dist/src/main/smoketest/compatibility/read.robot:
##########
@@ -37,4 +37,12 @@ Dir Can Be Listed Using Shell
File Can Be Get
Execute ozone fs -get o3fs://bucket1.vol1/dir-${SUFFIX}/file-${SUFFIX} /tmp/
Execute diff -q ${TESTFILE} /tmp/file-${SUFFIX}
- [teardown] Execute rm /tmp/file-${SUFFIX}
+ [teardown] Execute rm -f /tmp/file-${SUFFIX}
+
+FSO Bucket Can Be Read
Review Comment:
@adoroszlai maybe I'm wrong but it looks like we are consuming here the result of test from write.robot.
If it is not I'm confused why have teardown in one case and not in the other.
More or less want just to clarify things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11134. Create compatibility test for FSO bucket usage [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #7350:
URL: https://github.com/apache/ozone/pull/7350#issuecomment-2440707901
@sadanand48 @ssulav @tanvipenumudy can you please review this small patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org