You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/02 07:37:24 UTC

[GitHub] [apisix-dashboard] Jaycean commented on a change in pull request #1416: fix(be): CI uses the apisix-docker project dockerfile to build apisix

Jaycean commented on a change in pull request #1416:
URL: https://github.com/apache/apisix-dashboard/pull/1416#discussion_r568379640



##########
File path: .github/workflows/backend-e2e-test.yml
##########
@@ -20,6 +20,11 @@ jobs:
         with:
           go-version: '1.13'
 
+      - name: download file Dockerfile-apisix
+        working-directory: ./api/test/docker
+        run: |
+          curl -o Dockerfile-apisix https://raw.githubusercontent.com/apache/apisix-docker/master/all-in-one/apisix/Dockerfile

Review comment:
       Thks, I may try the @imjoey method, so that I don't need to modify the yaml file, I just need to modify the docker compose file.
   After modification, we only need to maintain the docker file of apisix-docker. At present, apisix Dockerfile is modified, and apiSix-dashboard Dockerfile-apisix also needs to be modified repeatedly.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org