You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2021/12/01 08:06:54 UTC
[GitHub] [bookkeeper] aloyszhang opened a new pull request #2918: remove legacy code to resole class missing error
aloyszhang opened a new pull request #2918:
URL: https://github.com/apache/bookkeeper/pull/2918
Descriptions of the changes in this PR:
On the master branch, TestTxnId can't find the dependency of `org.apache.bookkeeper.bookie.TestBookieImpl`.
### Motivation
remote the dependency and legacy code since it's not used
### Changes
remote the dependency and legacy code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] aloyszhang commented on pull request #2918: remove legacy code to resole class missing error
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #2918:
URL: https://github.com/apache/bookkeeper/pull/2918#issuecomment-984539263
@eolivelli PTAL, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] aloyszhang commented on pull request #2918: remove legacy code to resole class missing error
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #2918:
URL: https://github.com/apache/bookkeeper/pull/2918#issuecomment-985336897
@Vanlightly I think this pull request is ready to merge. PTAL, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] aloyszhang edited a comment on pull request #2918: remove legacy code to resole class missing error
Posted by GitBox <gi...@apache.org>.
aloyszhang edited a comment on pull request #2918:
URL: https://github.com/apache/bookkeeper/pull/2918#issuecomment-985336897
@Vanlightly @dlg99 I think this pull request is ready to merge. PTAL, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] gaozhangmin commented on pull request #2918: remove legacy code to resole class missing error
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #2918:
URL: https://github.com/apache/bookkeeper/pull/2918#issuecomment-983410747
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli merged pull request #2918: remove legacy code to resole class missing error
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #2918:
URL: https://github.com/apache/bookkeeper/pull/2918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org