You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "rohityadav1993 (via GitHub)" <gi...@apache.org> on 2026/05/27 04:39:05 UTC

[PR] feat(array): add arraySliceLong scalar function [pinot]

rohityadav1993 opened a new pull request, #18591:
URL: https://github.com/apache/pinot/pull/18591

   ## Summary
   
   - Adds `arraySliceLong(long[], int, int)` scalar function to complement the existing `arraySliceInt` and `arraySliceString`, filling a gap in the LONG-typed array function family.
   - Delegates to `Arrays.copyOfRange` — same implementation pattern as `arraySliceInt`.
   - Updates the UDF function snapshot (`all-functions.yaml`) to register the new function.
   
   ## Changes
   
   | File | Change |
   |---|---|
   | `ArrayFunctions.java` | New `@ScalarFunction arraySliceLong` |
   | `ArrayFunctionsTest.java` | Unit test via `InbuiltFunctionEvaluator` |
   | `ScalarTransformFunctionWrapperTest.java` | Transform-layer test against `LONG_MV_COLUMN` |
   | `ArrayTest.java` | Integration test through broker→server pipeline, both SSE and MSE |
   | `all-functions.yaml` | Snapshot entry for `arrayslicelong` |
   
   ## Test plan
   
   - [x] `ArrayFunctionsTest` — 46/46 pass
   - [x] `ScalarTransformFunctionWrapperTest` — 91/91 pass (90 existing + 1 new)
   - [x] `ArrayTest#testArraySliceLong` — integration test covering SSE and MSE query engines
   - [x] `UdfTest` snapshot updated (`all-functions.yaml`)
   - [x] Spotless, checkstyle, license checks all pass
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] feat(array): add arraySliceLong scalar function [pinot]

Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on PR #18591:
URL: https://github.com/apache/pinot/pull/18591#issuecomment-4587264148

   Docs update for this merged change is up at https://github.com/pinot-contrib/pinot-docs/pull/828 and will be merged once the docs checks pass.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] feat(array): add arraySliceLong scalar function [pinot]

Posted by "rohityadav1993 (via GitHub)" <gi...@apache.org>.
rohityadav1993 commented on PR #18591:
URL: https://github.com/apache/pinot/pull/18591#issuecomment-4552738680

   cc: @xiangfu0 for review as you have done similar contribution in the past. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] feat(array): add arraySliceLong scalar function [pinot]

Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 merged PR #18591:
URL: https://github.com/apache/pinot/pull/18591


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] feat(array): add arraySliceLong scalar function [pinot]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18591:
URL: https://github.com/apache/pinot/pull/18591#issuecomment-4551615315

   ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/18591?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 56.78%. Comparing base ([`3d62d6f`](https://app.codecov.io/gh/apache/pinot/commit/3d62d6fcd54c0c79b063c08da54b7338a7e9b713?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bb46f81`](https://app.codecov.io/gh/apache/pinot/commit/bb46f81180017b220b101d78766bf91a28870315?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 2 commits behind head on master.
   > :exclamation:  There is a different number of reports uploaded between BASE (3d62d6f) and HEAD (bb46f81). Click for more details.
   > 
   > <details><summary>HEAD has 16 uploads less than BASE</summary>
   >
   >| Flag | BASE (3d62d6f) | HEAD (bb46f81) |
   >|------|------|------|
   >|java-21|5|1|
   >|unittests|2|1|
   >|temurin|5|1|
   >|unittests2|1|0|
   >|integration|3|0|
   >|integration1|1|0|
   >|integration2|1|0|
   >|custom-integration1|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18591      +/-   ##
   ============================================
   - Coverage     64.28%   56.78%   -7.50%     
   + Complexity     1137        1    -1136     
   ============================================
     Files          3335     2564     -771     
     Lines        205895   148953   -56942     
     Branches      32129    24099    -8030     
   ============================================
   - Hits         132359    84589   -47770     
   + Misses        62888    57180    -5708     
   + Partials      10648     7184    -3464     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/pinot/pull/18591/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/18591/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [integration](https://app.codecov.io/gh/apache/pinot/pull/18591/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [integration1](https://app.codecov.io/gh/apache/pinot/pull/18591/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [integration2](https://app.codecov.io/gh/apache/pinot/pull/18591/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [java-21](https://app.codecov.io/gh/apache/pinot/pull/18591/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.78% <100.00%> (-7.50%)` | :arrow_down: |
   | [temurin](https://app.codecov.io/gh/apache/pinot/pull/18591/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.78% <100.00%> (-7.50%)` | :arrow_down: |
   | [unittests](https://app.codecov.io/gh/apache/pinot/pull/18591/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.78% <100.00%> (-7.50%)` | :arrow_down: |
   | [unittests1](https://app.codecov.io/gh/apache/pinot/pull/18591/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.78% <100.00%> (+0.03%)` | :arrow_up: |
   | [unittests2](https://app.codecov.io/gh/apache/pinot/pull/18591/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/pinot/pull/18591?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org