[GitHub] [solr] andywebb1975 commented on pull request #875: SOLR-9359: Make Config API work for warming queries

[GitBox <gi...@apache.org>]

andywebb1975 commented on PR #875:
URL: https://github.com/apache/solr/pull/875#issuecomment-1201532930

   So I've been looking at the tests side of this some more, and realised the ones we've added here work without the modifications being in place: if the JSON warming config is given to the Config API it'll accepts the updates and they appear in the response from `/config`, but there would _subsequently_ be a `ClassCastException` when `QuerySenderListener` runs.
   
   I don't know if there's a better approach to checking the QSL worked, but I've been trying to create a test that checks the caches have the expected number of entries driven by cache warming. Does that make sense? My efforts so far are in the WIP commit in my [solr-9359](https://github.com/apache/solr/compare/main...andywebb1975:solr:solr-9359) branch. But it's not working as I hoped - there's a null in the `/admin/mbeans?stats=true` response where I expected to see cache stats :-( I _suspect_ it might be a configuration error...
   
   Aside from that, the first commit in that other branch is a consolidated version of this one - does it look OK to you? I could sync this original branch with that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org