You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2017/05/24 23:45:55 UTC
Review Request 59551: Change launcher working directory before
dropping privilege.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59551/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Jiang Yan Xu.
Bugs: MESOS-7476
https://issues.apache.org/jira/browse/MESOS-7476
Repository: mesos
Description
-------
The launcher needs to change its working directory before dropping
privilege by switching users and installing capabilities, because
afterwards it might not have access to traverse to the desired
working directory.
Diffs
-----
src/slave/containerizer/mesos/launch.cpp f48d294a0a832dfe248c4a83849ee5a63cb76bce
Diff: https://reviews.apache.org/r/59551/diff/1/
Testing
-------
make check (Fedora 25)
Thanks,
James Peach
Re: Review Request 59551: Change launcher working directory before
dropping privilege.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59551/
-----------------------------------------------------------
(Updated June 5, 2017, 4:26 p.m.)
Review request for mesos, Jie Yu and Jiang Yan Xu.
Changes
-------
Rebased.
Bugs: MESOS-7476
https://issues.apache.org/jira/browse/MESOS-7476
Repository: mesos
Description
-------
The launcher needs to change its working directory before dropping
privilege by switching users and installing capabilities, because
afterwards it might not have access to traverse to the desired
working directory.
Diffs (updated)
-----
src/slave/containerizer/mesos/launch.cpp f48d294a0a832dfe248c4a83849ee5a63cb76bce
Diff: https://reviews.apache.org/r/59551/diff/2/
Changes: https://reviews.apache.org/r/59551/diff/1-2/
Testing
-------
make check (Fedora 25)
Thanks,
James Peach
Re: Review Request 59551: Change launcher working directory before
dropping privilege.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59551/#review176527
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On May 24, 2017, 11:45 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59551/
> -----------------------------------------------------------
>
> (Updated May 24, 2017, 11:45 p.m.)
>
>
> Review request for mesos, Jie Yu and Jiang Yan Xu.
>
>
> Bugs: MESOS-7476
> https://issues.apache.org/jira/browse/MESOS-7476
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The launcher needs to change its working directory before dropping
> privilege by switching users and installing capabilities, because
> afterwards it might not have access to traverse to the desired
> working directory.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/launch.cpp f48d294a0a832dfe248c4a83849ee5a63cb76bce
>
>
> Diff: https://reviews.apache.org/r/59551/diff/1/
>
>
> Testing
> -------
>
> make check (Fedora 25)
>
>
> Thanks,
>
> James Peach
>
>