You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/09/08 15:40:33 UTC

[GitHub] [shardingsphere] taojintianxia opened a new pull request, #20893: Refactor : refactor the integration test with code conduct

taojintianxia opened a new pull request, #20893:
URL: https://github.com/apache/shardingsphere/pull/20893

   
   
   Changes proposed in this pull request:
     - Format the code
     - replace magic variables with constants
     - avoid memory leak
   
   <img width="964" alt="image" src="https://user-images.githubusercontent.com/4112856/189165192-315736df-dd9f-4364-9f7f-c30cd1313662.png">
   
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [x] I have self-reviewed the commit code.
   - [x] I have triggered maven check: `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
   - [x] I have made corresponding changes to the documentation.
   - [x] I have added corresponding unit tests for my changes.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] terrymanu merged pull request #20893: Refactor : refactor the integration test with code conduct

Posted by GitBox <gi...@apache.org>.
terrymanu merged PR #20893:
URL: https://github.com/apache/shardingsphere/pull/20893


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org