You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "dweiss (via GitHub)" <gi...@apache.org> on 2025/09/26 11:58:23 UTC
[PR] Upgrade to Gradle 9.1.0 [lucene]
dweiss opened a new pull request, #15236:
URL: https://github.com/apache/lucene/pull/15236
This is a work in progress patch.
I've tried to assess how much is not working after an upgrade to gradle 9.1.0 and it seems most of the infrastructure works fine. Regeneration doesn't work (I know why). I'll try to push it forward but it seems like it's not going to be as complicated as I thought.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Upgrade to Gradle 9.1.0 [lucene]
Posted by "rmuir (via GitHub)" <gi...@apache.org>.
rmuir commented on PR #15236:
URL: https://github.com/apache/lucene/pull/15236#issuecomment-3344116436
Wow, I think merge now to reduce any hassles and let's smooth anything out as a followup?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Upgrade to Gradle 9.1.0 [lucene]
Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss commented on code in PR #15236:
URL: https://github.com/apache/lucene/pull/15236#discussion_r2387484980
##########
build.gradle:
##########
@@ -57,3 +56,11 @@ plugins {
}
description = 'Grandparent project for Apache Lucene Core'
+
+// Turn off all forbidden-apis tasks until it supports JDK 25;
+// https://github.com/policeman-tools/forbidden-apis/pull/272
+allprojects {
+ tasks.withType(CheckForbiddenApis.class).configureEach {
+ enabled = false
Review Comment:
I'll do this as an interim commit under #15246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Upgrade to Gradle 9.1.0 [lucene]
Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss commented on PR #15236:
URL: https://github.com/apache/lucene/pull/15236#issuecomment-3344129022
Merging this will also need to be coordinated with switching all jenkins workflows to jdk 25... which I'm not sure is installed on worker machines (asf infra, uwe's box)? I'll create a sub-issue to investigate this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Upgrade to Gradle 9.1.0 [lucene]
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on code in PR #15236:
URL: https://github.com/apache/lucene/pull/15236#discussion_r2387474326
##########
build.gradle:
##########
@@ -57,3 +56,11 @@ plugins {
}
description = 'Grandparent project for Apache Lucene Core'
+
+// Turn off all forbidden-apis tasks until it supports JDK 25;
+// https://github.com/policeman-tools/forbidden-apis/pull/272
+allprojects {
+ tasks.withType(CheckForbiddenApis.class).configureEach {
+ enabled = false
Review Comment:
just reenable it like this: targetVersion = "24"
Then it runs, but with older signatures!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Upgrade to Gradle 9.1.0 [lucene]
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on code in PR #15236:
URL: https://github.com/apache/lucene/pull/15236#discussion_r2387483571
##########
README.md:
##########
@@ -40,7 +40,7 @@ comprehensive documentation, visit:
### Basic steps:
-1. Install [OpenJDK 24](https://jdk.java.net/archive/).
+1. Install [OpenJDK 25](https://jdk.java.net/archive/).
Review Comment:
Correct link is: https://jdk.java.net/25/ (but it may not be persistent)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Upgrade to Gradle 9.1.0 [lucene]
Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss commented on PR #15236:
URL: https://github.com/apache/lucene/pull/15236#issuecomment-3342040609
I've made some reasonable progress. I'll try to make ecj work tomorrow and see what's left.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Upgrade to Gradle 9.1.0 [lucene]
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on code in PR #15236:
URL: https://github.com/apache/lucene/pull/15236#discussion_r2387478531
##########
README.md:
##########
@@ -40,7 +40,7 @@ comprehensive documentation, visit:
### Basic steps:
-1. Install [OpenJDK 24](https://jdk.java.net/archive/).
+1. Install [OpenJDK 25](https://jdk.java.net/archive/).
Review Comment:
the link here only shows java 24 as latest. Maybe only point to home page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Upgrade to Gradle 9.1.0 [lucene]
Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss merged PR #15236:
URL: https://github.com/apache/lucene/pull/15236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Upgrade to Gradle 9.1.0 [lucene]
Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss commented on PR #15236:
URL: https://github.com/apache/lucene/pull/15236#issuecomment-3344105354
I think everything works... I checked everything locally and the gh workflow that verifies gradle upgrade sanity is also passing. We can wait for Uwe to release forbidden-apis or merge this in and remove the temporary code that turns forbidden apis off (#15246).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Upgrade to Gradle 9.1.0 [lucene]
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on code in PR #15236:
URL: https://github.com/apache/lucene/pull/15236#discussion_r2387474326
##########
build.gradle:
##########
@@ -57,3 +56,11 @@ plugins {
}
description = 'Grandparent project for Apache Lucene Core'
+
+// Turn off all forbidden-apis tasks until it supports JDK 25;
+// https://github.com/policeman-tools/forbidden-apis/pull/272
+allprojects {
+ tasks.withType(CheckForbiddenApis.class).configureEach {
+ enabled = false
Review Comment:
just reenable it like this: `targetVersion = "24"`
Then it runs, but with older signatures!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org