You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/08 10:43:16 UTC
[GitHub] [flink] gaoyunhaii commented on a diff in pull request #19395: [FLINK-27118][yarn] TM ignores localhost BIND_HOST
gaoyunhaii commented on code in PR #19395:
URL: https://github.com/apache/flink/pull/19395#discussion_r845984674
##########
flink-yarn/src/main/java/org/apache/flink/yarn/YarnTaskExecutorRunner.java:
##########
@@ -103,6 +103,11 @@ static void setupAndModifyConfiguration(
BootstrapTools.updateTmpDirectoriesInConfiguration(configuration, localDirs);
setupConfigurationFromVariables(configuration, currDir, variables);
+
+ configuration
Review Comment:
This should be unnecessary if we have already removed the configuration in the client side~?
##########
flink-yarn/src/main/java/org/apache/flink/yarn/YarnTaskExecutorRunner.java:
##########
@@ -103,6 +103,11 @@ static void setupAndModifyConfiguration(
BootstrapTools.updateTmpDirectoriesInConfiguration(configuration, localDirs);
setupConfigurationFromVariables(configuration, currDir, variables);
+
+ configuration
Review Comment:
This should be unnecessary if we have already removed the configuration in the client side~?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org