You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by ro...@apache.org on 2016/11/23 13:50:18 UTC

[15/46] james-project git commit: JAMES-1854 Use Optional to better write MailDispatcher Builder

JAMES-1854 Use Optional to better write MailDispatcher Builder


Project: http://git-wip-us.apache.org/repos/asf/james-project/repo
Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/09c522be
Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/09c522be
Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/09c522be

Branch: refs/heads/master
Commit: 09c522befecd5ffc795ed33ff584c6552ee2ea96
Parents: 42800ae
Author: Benoit Tellier <bt...@linagora.com>
Authored: Thu Nov 10 15:58:32 2016 +0700
Committer: Benoit Tellier <bt...@linagora.com>
Committed: Fri Nov 18 18:46:46 2016 +0700

----------------------------------------------------------------------
 .../james/transport/mailets/delivery/MailDispatcher.java      | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/james-project/blob/09c522be/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/delivery/MailDispatcher.java
----------------------------------------------------------------------
diff --git a/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/delivery/MailDispatcher.java b/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/delivery/MailDispatcher.java
index 3bcd662..04968a6 100644
--- a/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/delivery/MailDispatcher.java
+++ b/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/delivery/MailDispatcher.java
@@ -45,13 +45,14 @@ public class MailDispatcher {
     }
 
     public static class Builder {
+        public static final boolean CONSUME_DEFAULT_VALUE = true;
         private MailStore mailStore;
-        private boolean consume;
+        private Optional<Boolean> consume = Optional.absent();
         private MailetContext mailetContext;
         private Log log;
 
         public Builder consume(boolean consume) {
-            this.consume = consume;
+            this.consume = Optional.of(consume);
             return this;
         }
 
@@ -74,7 +75,7 @@ public class MailDispatcher {
             Preconditions.checkNotNull(mailStore);
             Preconditions.checkNotNull(log);
             Preconditions.checkNotNull(mailetContext);
-            return new MailDispatcher(mailStore, consume, log, mailetContext);
+            return new MailDispatcher(mailStore, consume.or(CONSUME_DEFAULT_VALUE), log, mailetContext);
         }
 
     }


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org