[jira] [Resolved] (CB-481) Patch Android cordova.js to call exec() instead of directly calling prompt()

["Filip Maj (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CB-481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Filip Maj resolved CB-481.
--------------------------

    Resolution: Fixed

Fixed; [Android commit 85aa74|https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-android.git;a=commit;h=85aa740c9864881db562bb1f1fcf672531fea8b1] and [JS commit df936f|https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-js.git;a=commit;h=df936f604266c971933d87eef0b124374d6871f5].
                
> Patch Android cordova.js to call exec() instead of directly calling prompt()
> ----------------------------------------------------------------------------
>
>                 Key: CB-481
>                 URL: https://issues.apache.org/jira/browse/CB-481
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android, CordovaJS
>    Affects Versions: 1.6.0, 1.7.0, 1.8.0, 1.8.1, 1.9.0
>            Reporter: Filip Maj
>            Assignee: Filip Maj
>            Priority: Minor
>             Fix For: 2.0.0
>
>
> The final call in Android's cordova-js after everything is ready is to tell native to unhide the webview. This is done via a {{prompt}} call with string "gap_init" or something along those lines.
> While this is fine, we already have the {{exec}} module in place to handle webview -> native communication. We should use that instead. It's kind of foolish to go one level below {{exec}} when we have the {{exec}} abstraction available and in place already.
> This would also help the testing tool Ripple: Android Cordova apps being emulated in Ripple would no longer see an annoying prompt following app startup!
> Bottom line: {{exec}} is our go-to for calling into native. Circumventing an abstraction we put into place does not make any sense, and unifies how our bridge works.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira