[GitHub] [incubator-kvrocks] paragor commented on a diff in pull request #1303: Support replica-announce-ip and replica-announce-port

["paragor (via GitHub)" <gi...@apache.org>]

paragor commented on code in PR #1303:
URL: https://github.com/apache/incubator-kvrocks/pull/1303#discussion_r1130599593


##########
src/server/redis_connection.h:
##########
@@ -90,6 +90,9 @@ class Connection {
   uint32_t GetPort() { return port_; }
   void SetListeningPort(int port) { listening_port_ = port; }
   int GetListeningPort() { return listening_port_; }
+  void SetAnnounceIP(std::string ip) { announce_ip_ = std::move(ip); }

Review Comment:
   i think i forgot to add opportunity to kill client via  announce addr 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org