[GitHub] [cassandra] mghildiy edited a comment on pull request #1368: WIP: CASSANDRA-17190:Changes to add support for string concatenations through the + operator

[GitBox <gi...@apache.org>]

mghildiy edited a comment on pull request #1368:
URL: https://github.com/apache/cassandra/pull/1368#issuecomment-1001043882


   I think there is still some thing I am missing in code.
   
   I modified one of the existing test as:
   
   ```
   createTable("CREATE TABLE %s (a tinyint, b smallint, c int, d bigint, e float, f double, g varint, h decimal, i text, j text, PRIMARY KEY(a, b, c))");
           execute("INSERT INTO %S (a, b, c, d, e, f, g, h, i, j) VALUES (1, 2, 3, 4, 5.5, 6.5, 7, 8.5, 'John', 'Doe')");
   
           // Test additions
           UntypedResultSet rs = execute("SELECT a + a, b + a, c + a, d + a, e + a, f + a, g + a, h + a, i + j FROM %s WHERE a = 1 AND b = 2 AND c = 1 + 2"); 
   ```
   During debugging for above, I observe that Collection<Function> instance returned by FunctionResolver.collectCandidates for i and j doesn't have the function for our desired combination (text/ascii, text/ascii).
   
   **Note**:
   In OperationFcts.java, I see NumericOperationFunction, TemporalOperationFunction implemented. Maybe I need to implement a similar class for string types.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org