You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2019/01/15 14:34:39 UTC
[GitHub] scottpas commented on a change in pull request #355: GUACAMOLE-271:
Duo in docker image
scottpas commented on a change in pull request #355: GUACAMOLE-271: Duo in docker image
URL: https://github.com/apache/guacamole-client/pull/355#discussion_r247915054
##########
File path: guacamole-docker/bin/start.sh
##########
@@ -591,6 +591,18 @@ END
exit 1;
fi
+# Use Duo if specified
+if [ -n "$DUO_API_HOSTNAME" ] && \
+ [ -n "$DUO_INTEGRATION_KEY" ] && \
+ [ -n "$DUO_SECRET_KEY" ] && \
+ [ -n "$DUO_APPLICATION_KEY" ] ; then
+ set_optional_property "duo-api-hostname" "$DUO_API_HOSTNAME"
+ set_optional_property "duo-integration-key" "$DUO_INTEGRATION_KEY"
+ set_optional_property "duo-secret-key" "$DUO_SECRET_KEY"
Review comment:
Ok, changes made! Let me know if you think any others are necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services