You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2017/09/07 15:12:37 UTC
Review Request 62158: Rescinded offers possibly affected by updates
to agent total resources.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62158/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Jan Schlicht.
Bugs: MESOS-7757
https://issues.apache.org/jira/browse/MESOS-7757
Repository: mesos
Description
-------
When an agent changes its resources, the master should rescind any
offers affected by the change. We already performed the rescind for
updates to the agent's oversubscribed resources; this patch adds offer
rescinding when an update an agent's total resources is processed.
While for updates to an agent's oversubscribed resources we currently
only rescind offers containing revocable resources to e.g., reduce
offer churn, we for updates to the total we here currently rescind all
offers for resources on the agent.
Diffs
-----
src/master/master.cpp 53ee87ad8e770a91ecbd6822cd31012811848698
Diff: https://reviews.apache.org/r/62158/diff/1/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 62158: Rescinded offers possibly affected by
updates to agent total resources.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62158/#review186108
-----------------------------------------------------------
Ship it!
Ship It!
- Jan Schlicht
On Sept. 20, 2017, 4:24 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62158/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2017, 4:24 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-7757
> https://issues.apache.org/jira/browse/MESOS-7757
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When an agent changes its resources, the master should rescind any
> offers affected by the change. We already performed the rescind for
> updates to the agent's oversubscribed resources; this patch adds offer
> rescinding when an update an agent's total resources is processed.
>
> While for updates to an agent's oversubscribed resources we currently
> only rescind offers containing revocable resources to e.g., reduce
> offer churn, we for updates to the total we here currently rescind all
> offers for resources on the agent.
>
>
> Diffs
> -----
>
> src/master/master.cpp 6d84a26bff970b842b58dfb69dbf232ba5c16a20
>
>
> Diff: https://reviews.apache.org/r/62158/diff/4/
>
>
> Testing
> -------
>
> Tested on a number of platforms on internal CI.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 62158: Rescinded offers possibly affected by
updates to agent total resources.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62158/#review186601
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Sept. 28, 2017, 6:42 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62158/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2017, 6:42 a.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-7757
> https://issues.apache.org/jira/browse/MESOS-7757
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When an agent changes its resources, the master should rescind any
> offers affected by the change. We already performed the rescind for
> updates to the agent's oversubscribed resources; this patch adds offer
> rescinding when an update an agent's total resources is processed.
>
> While for updates to an agent's oversubscribed resources we currently
> only rescind offers containing revocable resources to e.g., reduce
> offer churn, we for updates to the total we here currently rescind all
> offers for resources on the agent.
>
>
> Diffs
> -----
>
> src/master/master.cpp 6d84a26bff970b842b58dfb69dbf232ba5c16a20
>
>
> Diff: https://reviews.apache.org/r/62158/diff/5/
>
>
> Testing
> -------
>
> Tested on a number of platforms on internal CI.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 62158: Rescinded offers possibly affected by
updates to agent total resources.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62158/#review186983
-----------------------------------------------------------
Fix it, then Ship it!
src/master/master.cpp
Line 6841 (original), 6841 (patched)
<https://reviews.apache.org/r/62158/#comment263936>
For consistency, we still use 'Slave' for variable names (in this file). Let's use newSlaveTotalResources here.
- Jie Yu
On Oct. 2, 2017, 4:53 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62158/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2017, 4:53 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-7757
> https://issues.apache.org/jira/browse/MESOS-7757
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When an agent changes its resources, the master should rescind any
> offers affected by the change. We already performed the rescind for
> updates to the agent's oversubscribed resources; this patch adds offer
> rescinding when an update an agent's total resources is processed.
>
> While for updates to an agent's oversubscribed resources we currently
> only rescind offers containing revocable resources to e.g., reduce
> offer churn, for updates to the total we here currently rescind all
> offers for resources on the agent.
>
> As an optimization, this patch adds logic to ignore redundant updates
> to agent resources.
>
>
> Diffs
> -----
>
> src/master/master.cpp b40621ee3870b1968ab1b05dd0f41a489f4db00e
>
>
> Diff: https://reviews.apache.org/r/62158/diff/7/
>
>
> Testing
> -------
>
> Tested on a number of platforms on internal CI.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 62158: Rescinded offers possibly affected by
updates to agent total resources.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62158/
-----------------------------------------------------------
(Updated Oct. 2, 2017, 6:53 p.m.)
Review request for mesos, Jie Yu and Jan Schlicht.
Changes
-------
Rebased.
Bugs: MESOS-7757
https://issues.apache.org/jira/browse/MESOS-7757
Repository: mesos
Description (updated)
-------
When an agent changes its resources, the master should rescind any
offers affected by the change. We already performed the rescind for
updates to the agent's oversubscribed resources; this patch adds offer
rescinding when an update an agent's total resources is processed.
While for updates to an agent's oversubscribed resources we currently
only rescind offers containing revocable resources to e.g., reduce
offer churn, for updates to the total we here currently rescind all
offers for resources on the agent.
As an optimization, this patch adds logic to ignore redundant updates
to agent resources.
Diffs (updated)
-----
src/master/master.cpp b40621ee3870b1968ab1b05dd0f41a489f4db00e
Diff: https://reviews.apache.org/r/62158/diff/7/
Changes: https://reviews.apache.org/r/62158/diff/6-7/
Testing
-------
Tested on a number of platforms on internal CI.
Thanks,
Benjamin Bannier
Re: Review Request 62158: Rescinded offers possibly affected by
updates to agent total resources.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62158/
-----------------------------------------------------------
(Updated Sept. 29, 2017, 11:14 a.m.)
Review request for mesos, Jie Yu and Jan Schlicht.
Changes
-------
Rebased.
Bugs: MESOS-7757
https://issues.apache.org/jira/browse/MESOS-7757
Repository: mesos
Description
-------
When an agent changes its resources, the master should rescind any
offers affected by the change. We already performed the rescind for
updates to the agent's oversubscribed resources; this patch adds offer
rescinding when an update an agent's total resources is processed.
While for updates to an agent's oversubscribed resources we currently
only rescind offers containing revocable resources to e.g., reduce
offer churn, we for updates to the total we here currently rescind all
offers for resources on the agent.
Diffs (updated)
-----
src/master/master.cpp 6d84a26bff970b842b58dfb69dbf232ba5c16a20
Diff: https://reviews.apache.org/r/62158/diff/6/
Changes: https://reviews.apache.org/r/62158/diff/5-6/
Testing
-------
Tested on a number of platforms on internal CI.
Thanks,
Benjamin Bannier
Re: Review Request 62158: Rescinded offers possibly affected by
updates to agent total resources.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62158/
-----------------------------------------------------------
(Updated Sept. 28, 2017, 8:42 a.m.)
Review request for mesos, Jie Yu and Jan Schlicht.
Changes
-------
Rebased.
Bugs: MESOS-7757
https://issues.apache.org/jira/browse/MESOS-7757
Repository: mesos
Description
-------
When an agent changes its resources, the master should rescind any
offers affected by the change. We already performed the rescind for
updates to the agent's oversubscribed resources; this patch adds offer
rescinding when an update an agent's total resources is processed.
While for updates to an agent's oversubscribed resources we currently
only rescind offers containing revocable resources to e.g., reduce
offer churn, we for updates to the total we here currently rescind all
offers for resources on the agent.
Diffs (updated)
-----
src/master/master.cpp 6d84a26bff970b842b58dfb69dbf232ba5c16a20
Diff: https://reviews.apache.org/r/62158/diff/5/
Changes: https://reviews.apache.org/r/62158/diff/4-5/
Testing
-------
Tested on a number of platforms on internal CI.
Thanks,
Benjamin Bannier
Re: Review Request 62158: Rescinded offers possibly affected by
updates to agent total resources.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62158/
-----------------------------------------------------------
(Updated Sept. 20, 2017, 4:24 p.m.)
Review request for mesos, Jie Yu and Jan Schlicht.
Changes
-------
Added a `break` to logging code.
Bugs: MESOS-7757
https://issues.apache.org/jira/browse/MESOS-7757
Repository: mesos
Description
-------
When an agent changes its resources, the master should rescind any
offers affected by the change. We already performed the rescind for
updates to the agent's oversubscribed resources; this patch adds offer
rescinding when an update an agent's total resources is processed.
While for updates to an agent's oversubscribed resources we currently
only rescind offers containing revocable resources to e.g., reduce
offer churn, we for updates to the total we here currently rescind all
offers for resources on the agent.
Diffs (updated)
-----
src/master/master.cpp 6d84a26bff970b842b58dfb69dbf232ba5c16a20
Diff: https://reviews.apache.org/r/62158/diff/4/
Changes: https://reviews.apache.org/r/62158/diff/3-4/
Testing (updated)
-------
Tested on a number of platforms on internal CI.
Thanks,
Benjamin Bannier
Re: Review Request 62158: Rescinded offers possibly affected by
updates to agent total resources.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62158/
-----------------------------------------------------------
(Updated Sept. 19, 2017, 6:53 p.m.)
Review request for mesos, Jie Yu and Jan Schlicht.
Changes
-------
Rebased.
Bugs: MESOS-7757
https://issues.apache.org/jira/browse/MESOS-7757
Repository: mesos
Description
-------
When an agent changes its resources, the master should rescind any
offers affected by the change. We already performed the rescind for
updates to the agent's oversubscribed resources; this patch adds offer
rescinding when an update an agent's total resources is processed.
While for updates to an agent's oversubscribed resources we currently
only rescind offers containing revocable resources to e.g., reduce
offer churn, we for updates to the total we here currently rescind all
offers for resources on the agent.
Diffs (updated)
-----
src/master/master.cpp 6d84a26bff970b842b58dfb69dbf232ba5c16a20
Diff: https://reviews.apache.org/r/62158/diff/3/
Changes: https://reviews.apache.org/r/62158/diff/2-3/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 62158: Rescinded offers possibly affected by
updates to agent total resources.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62158/#review185571
-----------------------------------------------------------
Fix it, then Ship it!
src/master/master.cpp
Lines 6779-6781 (original), 6787-6789 (patched)
<https://reviews.apache.org/r/62158/#comment261885>
Why change the formatting. I think the old style is better.
src/master/master.cpp
Lines 6797-6798 (patched)
<https://reviews.apache.org/r/62158/#comment261887>
Ditto on logging style. Please be consistent with others in this file.
- Jie Yu
On Sept. 15, 2017, 1:15 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62158/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2017, 1:15 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-7757
> https://issues.apache.org/jira/browse/MESOS-7757
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When an agent changes its resources, the master should rescind any
> offers affected by the change. We already performed the rescind for
> updates to the agent's oversubscribed resources; this patch adds offer
> rescinding when an update an agent's total resources is processed.
>
> While for updates to an agent's oversubscribed resources we currently
> only rescind offers containing revocable resources to e.g., reduce
> offer churn, we for updates to the total we here currently rescind all
> offers for resources on the agent.
>
>
> Diffs
> -----
>
> src/master/master.cpp 6d84a26bff970b842b58dfb69dbf232ba5c16a20
>
>
> Diff: https://reviews.apache.org/r/62158/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 62158: Rescinded offers possibly affected by
updates to agent total resources.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62158/
-----------------------------------------------------------
(Updated Sept. 15, 2017, 3:15 p.m.)
Review request for mesos, Jie Yu and Jan Schlicht.
Changes
-------
Rebased.
Bugs: MESOS-7757
https://issues.apache.org/jira/browse/MESOS-7757
Repository: mesos
Description
-------
When an agent changes its resources, the master should rescind any
offers affected by the change. We already performed the rescind for
updates to the agent's oversubscribed resources; this patch adds offer
rescinding when an update an agent's total resources is processed.
While for updates to an agent's oversubscribed resources we currently
only rescind offers containing revocable resources to e.g., reduce
offer churn, we for updates to the total we here currently rescind all
offers for resources on the agent.
Diffs (updated)
-----
src/master/master.cpp 6d84a26bff970b842b58dfb69dbf232ba5c16a20
Diff: https://reviews.apache.org/r/62158/diff/2/
Changes: https://reviews.apache.org/r/62158/diff/1-2/
Testing
-------
`make check`
Thanks,
Benjamin Bannier