You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2015/08/14 01:52:20 UTC
Review Request 37455: Moving ResourceAggregates into scheduler
package.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37455/
-----------------------------------------------------------
Review request for Aurora and Zameer Manji.
Bugs: AURORA-1415
https://issues.apache.org/jira/browse/AURORA-1415
Repository: aurora
Description
-------
My initial thought was to merge this with ResourceSlot but it did not feel right due to lack of shared functionality. Moving it alongside other resource management files for easier discoverability.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/base/ResourceAggregates.java 5ae27f9338c1e77c8a901a329c84d4a1433e682f
src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 7f5e45bb0f88a55d9049c2570426201260c67161
src/main/java/org/apache/aurora/scheduler/sla/SlaGroup.java d9a3c4812988df5fd651eadad47b49d283b21436
src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java 5de34b2fb2d6fa6926021092d2fc4b7a06c2ccbc
src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 2d90536ddabcdd4a834eb61136742c6a43d634f4
src/test/java/org/apache/aurora/scheduler/stats/SlotSizeCounterTest.java 41f14f967074c75e996a19c90692a4d08e9db71a
src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java 20b2ff88cbf397c2c0561e87e6b9966dfb798a14
Diff: https://reviews.apache.org/r/37455/diff/
Testing
-------
Thanks,
Maxim Khutornenko
Re: Review Request 37455: Moving ResourceAggregates into scheduler
package.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37455/#review95360
-----------------------------------------------------------
Ship it!
Master (76d5a49) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Aug. 13, 2015, 11:53 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37455/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2015, 11:53 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Bugs: AURORA-1415
> https://issues.apache.org/jira/browse/AURORA-1415
>
>
> Repository: aurora
>
>
> Description
> -------
>
> My initial thought was to merge this with ResourceSlot but it did not feel right due to lack of shared functionality. Moving it alongside other resource management files for easier discoverability.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/base/ResourceAggregates.java 5ae27f9338c1e77c8a901a329c84d4a1433e682f
> src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 7f5e45bb0f88a55d9049c2570426201260c67161
> src/main/java/org/apache/aurora/scheduler/sla/SlaGroup.java d9a3c4812988df5fd651eadad47b49d283b21436
> src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java 5de34b2fb2d6fa6926021092d2fc4b7a06c2ccbc
> src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 2d90536ddabcdd4a834eb61136742c6a43d634f4
> src/test/java/org/apache/aurora/scheduler/stats/SlotSizeCounterTest.java 41f14f967074c75e996a19c90692a4d08e9db71a
> src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java 20b2ff88cbf397c2c0561e87e6b9966dfb798a14
>
> Diff: https://reviews.apache.org/r/37455/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 37455: Moving ResourceAggregates into scheduler
package.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37455/#review95361
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On Aug. 13, 2015, 4:53 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37455/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2015, 4:53 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Bugs: AURORA-1415
> https://issues.apache.org/jira/browse/AURORA-1415
>
>
> Repository: aurora
>
>
> Description
> -------
>
> My initial thought was to merge this with ResourceSlot but it did not feel right due to lack of shared functionality. Moving it alongside other resource management files for easier discoverability.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/base/ResourceAggregates.java 5ae27f9338c1e77c8a901a329c84d4a1433e682f
> src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 7f5e45bb0f88a55d9049c2570426201260c67161
> src/main/java/org/apache/aurora/scheduler/sla/SlaGroup.java d9a3c4812988df5fd651eadad47b49d283b21436
> src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java 5de34b2fb2d6fa6926021092d2fc4b7a06c2ccbc
> src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 2d90536ddabcdd4a834eb61136742c6a43d634f4
> src/test/java/org/apache/aurora/scheduler/stats/SlotSizeCounterTest.java 41f14f967074c75e996a19c90692a4d08e9db71a
> src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java 20b2ff88cbf397c2c0561e87e6b9966dfb798a14
>
> Diff: https://reviews.apache.org/r/37455/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 37455: Moving ResourceAggregates into scheduler
package.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37455/
-----------------------------------------------------------
(Updated Aug. 13, 2015, 11:53 p.m.)
Review request for Aurora and Zameer Manji.
Changes
-------
Adding blocking parent CR.
Bugs: AURORA-1415
https://issues.apache.org/jira/browse/AURORA-1415
Repository: aurora
Description
-------
My initial thought was to merge this with ResourceSlot but it did not feel right due to lack of shared functionality. Moving it alongside other resource management files for easier discoverability.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/base/ResourceAggregates.java 5ae27f9338c1e77c8a901a329c84d4a1433e682f
src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 7f5e45bb0f88a55d9049c2570426201260c67161
src/main/java/org/apache/aurora/scheduler/sla/SlaGroup.java d9a3c4812988df5fd651eadad47b49d283b21436
src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java 5de34b2fb2d6fa6926021092d2fc4b7a06c2ccbc
src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 2d90536ddabcdd4a834eb61136742c6a43d634f4
src/test/java/org/apache/aurora/scheduler/stats/SlotSizeCounterTest.java 41f14f967074c75e996a19c90692a4d08e9db71a
src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java 20b2ff88cbf397c2c0561e87e6b9966dfb798a14
Diff: https://reviews.apache.org/r/37455/diff/
Testing
-------
Thanks,
Maxim Khutornenko