You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/10/01 05:33:45 UTC
[GitHub] [iceberg] kbendick opened a new issue #1541: Update FlinkCatalog to use Namespace for baseNamespace field for cleaner output
kbendick opened a new issue #1541:
URL: https://github.com/apache/iceberg/issues/1541
The FlinkCatalog currently has a `String[] baseNamespace` field. However, when adding in names to the parameterized tests in this PR: https://github.com/apache/iceberg/pull/1539, I noticed that the output for the `baseNamespaces` parameters came out as `(new String[]{"a", "b"}).toString()`.
In order to make the tests more human readable, we're going to accept that a baseNamespace is simply a prefix of a `Namespace` (especially considering that there's not really a limit on the number of dots in a namespace).
I'm going to refactor FlinkCatalog to use `Namespace` for that field so that we can take advantage of its preexisting static constructor `Namespace.from(String...)` as well as its proper `.toString` implementation.
This will make test output much more readable so we can see what values we're actually testing with just by running the tests, as well as potentially making stack traces that involve these fields easier to read.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on issue #1541: Update FlinkCatalog to use Namespace for baseNamespace field for cleaner output
Posted by GitBox <gi...@apache.org>.
kbendick commented on issue #1541:
URL: https://github.com/apache/iceberg/issues/1541#issuecomment-701908441
Currently, the test output for the parameterized name looks like the following when the tests are run (for reference)
```
testReplacePartitions[catalogName=testhadoop, baseNamespace=[Ljava.lang.String;36c1c7d9], format=PARQUET, isStreaming=false]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue closed issue #1541: Update FlinkCatalog to use Namespace for baseNamespace field for cleaner output
Posted by GitBox <gi...@apache.org>.
rdblue closed issue #1541:
URL: https://github.com/apache/iceberg/issues/1541
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on issue #1541: Update FlinkCatalog to use Namespace for baseNamespace field for cleaner output
Posted by GitBox <gi...@apache.org>.
rdblue commented on issue #1541:
URL: https://github.com/apache/iceberg/issues/1541#issuecomment-751842998
Fixed by #1984.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org