[GitHub] [accumulo] ctubbsii commented on a change in pull request #1354: Remove synchronization and use AtomicLong

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #1354: Remove synchronization and use AtomicLong
URL: https://github.com/apache/accumulo/pull/1354#discussion_r323060696
 
 

 ##########
 File path: server/master/src/main/java/org/apache/accumulo/master/MasterTime.java
 ##########
 @@ -104,7 +105,7 @@ public void run() {
       case UNLOAD_METADATA_TABLETS:
       case UNLOAD_ROOT_TABLET:
         try {
-          zk.putPersistentData(zPath, Long.toString(System.nanoTime() + skewAmount).getBytes(UTF_8),
+          zk.putPersistentData(zPath, Long.toString(System.nanoTime() + skewAmount.get()).getBytes(UTF_8),
 
 Review comment:
   This wasn't previously synchronized. Is there any risk that this will cause additional lock contention with the Master calling `getTime()` on this object? Or does this perhaps a fix a correctness bug? Or neither?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services