[GitHub] [arrow] kou commented on a change in pull request #11337: ARROW-9843: [C++] WIP Implement Between trinary kernel

[GitBox <gi...@apache.org>]

kou commented on a change in pull request #11337:
URL: https://github.com/apache/arrow/pull/11337#discussion_r758069690



##########
File path: cpp/src/arrow/compute/api_scalar.cc
##########
@@ -660,3 +668,4 @@ Result<Datum> Strftime(const Datum& arg, StrftimeOptions options, ExecContext* c
 
 }  // namespace compute
 }  // namespace arrow
+

Review comment:
       Could you revert a needless change?

##########
File path: cpp/src/arrow/compute/api_scalar.h
##########
@@ -1229,3 +1245,4 @@ ARROW_EXPORT Result<Datum> AssumeTimezone(const Datum& values,
 
 }  // namespace compute
 }  // namespace arrow
+

Review comment:
       Could you revert a needless change?

##########
File path: cpp/src/arrow/compute/api_scalar.h
##########
@@ -710,6 +710,22 @@ Result<Datum> MinElementWise(
     ElementWiseAggregateOptions options = ElementWiseAggregateOptions::Defaults(),
     ExecContext* ctx = NULLPTR);
 
+/// \brief Between compares each element in `values`
+/// with `left` as a lower bound and 'right' as an upperbound

Review comment:
       ```suggestion
   /// with `left` as a lower bound and 'right' as an upper bound
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org