[GitHub] [arrow-datafusion] tustvold commented on pull request #6785: Consistently coerce dictionaries for arithmetic

["tustvold (via GitHub)" <gi...@apache.org>]

tustvold commented on PR #6785:
URL: https://github.com/apache/arrow-datafusion/pull/6785#issuecomment-1614429330

   >  but also possible impact to other operations in the query engine
   
   To clarify this PR **does not alter the return type** of the evaluation, the output will still always be primitive. I therefore don't foresee this having downstream implications.
   
   This PR **only** changes the way that DF **evaluates** `dictionary op primitive`. Now instead of coercing the arguments to dictionaries it coerces them to primitives. This is now consistent with the existing behaviour for all other combinations of dictionaries and primitives,  `dictionary op dictionary`, `primitive op dictionary` and `primitive op primitive`, which coerce to primitives on main.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org