[jira] [Work logged] (ARTEMIS-3021) OOM due to wrong CORE clustered message memory estimation

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ARTEMIS-3021?focusedWorklogId=681547&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-681547 ]

ASF GitHub Bot logged work on ARTEMIS-3021:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Nov/21 14:49
            Start Date: 15/Nov/21 14:49
    Worklog Time Spent: 10m 
      Work Description: gtully commented on a change in pull request #3370:
URL: https://github.com/apache/activemq-artemis/pull/3370#discussion_r749395283



##########
File path: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ByteUtil.java
##########
@@ -389,6 +389,16 @@ private static boolean equalsUnsafe(final byte[] left,
       return true;
    }
 
+   /**
+    * This ensure a more exact resizing then {@link ByteBuf#ensureWritable(int), if needed.<br>

Review comment:
       this seems problematic:
   /home/runner/work/activemq-artemis/activemq-artemis/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ByteUtil.java:393: error: unexpected text after parenthesis
   Error:      * This ensure a more exact resizing then {@link ByteBuf#ensureWritable(int), if needed.<br>
   Error:                                               ^




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 681547)
    Time Spent: 4.5h  (was: 4h 20m)

> OOM due to wrong CORE clustered message memory estimation
> ---------------------------------------------------------
>
>                 Key: ARTEMIS-3021
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-3021
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Francesco Nigro
>            Assignee: Francesco Nigro
>            Priority: Major
>          Time Spent: 4.5h
>  Remaining Estimate: 0h
>
> This is affecting clustered Core messages (persistent or not).
> The process that cause the wrong estimation is:
>  # add route information to the message
>  # get memory estimation for paging (ie address size estimation) without accounting the new route information
>  # get message persist size for durable append on journal/to update queue statistics, triggering a re-encoding
>  # re-encoding (can) enlarge the message buffer to be the next power of 2 available capacity
> The 2 fixes are:
>  * getting a correct memory estimation of the message (including the added route information)
>  * save an excessive buffer growth caused by the default Netty's ByteBuf::ensureWritable strategy



--
This message was sent by Atlassian Jira
(v8.20.1#820001)