You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/17 11:36:37 UTC

[GitHub] [flink-docker] wangyang0918 edited a comment on pull request #49: [FLINK-20650] Rename "native-k8s" command to "generic" in docker-entrypoint.sh

wangyang0918 edited a comment on pull request #49:
URL: https://github.com/apache/flink-docker/pull/49#issuecomment-747384460


   @tillrohrmann Currently, in the Flink implementation, we are always passing the `native-k8s` as one of the arguments of JobManager container[1]. So when it changes in the flink-docker project, we need to update it accordingly. Also we need to add a `bash -c` wrapper for the commands so that all the arguments for java could be parsed correctly.
   
   I will attach a PR in Flink project soon.
   
   [1]. https://github.com/apache/flink/blob/master/flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/decorators/JavaCmdJobManagerDecorator.java#L64


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org