[GitHub] TisonKun opened a new pull request #7815: [FLINK-11710][tests] Remove Instance usages in valid Test

[GitBox <gi...@apache.org>]

TisonKun opened a new pull request #7815:  [FLINK-11710][tests] Remove Instance usages in valid Test
URL: https://github.com/apache/flink/pull/7815
 
 
   ## What is the purpose of the change
   
   **DOT MERGE**
   
   Based on #7809 . The last batch of FLINK-10569.
   
   1. Replace SimpleSlot to TestingLogicalSlot in `ExecutionVertexCancelTest`
   
   2. Add a `releaseAllocatedSlot` method in `TestingLogicalSlotProvider` to simulate `Instance#markDead`
   
   **3** still cannot port the last two tests `testRestartWithSlotSharingAndNotEnoughResources` and `testRestartWithEagerSchedulingAndSlotSharing`. The problem is that it test slot sharing and thus we need a testing slotprovider which support SlotSharing. I haven't successfully implemented it yet. Maybe I need some help from the community.
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector:(no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   
   cc @tillrohrmann @zentol 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services