You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/07/20 18:35:39 UTC
[GitHub] [beam] yeandy opened a new pull request, #22371: Remove normalization in Pytorch Image Segmentation example
yeandy opened a new pull request, #22371:
URL: https://github.com/apache/beam/pull/22371
Fixes https://github.com/apache/beam/issues/22224. I mistakenly added a normalization operation during the preprocessing step. This has been removed. The actuals [file](https://github.com/apache/beam/blob/master/sdks/python/apache_beam/ml/inference/pytorch_inference_it_test.py#L117) has also been overwritten with the updated outputs.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22371: Remove normalization in Pytorch Image Segmentation example
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22371:
URL: https://github.com/apache/beam/pull/22371#issuecomment-1198077529
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] yeandy commented on pull request #22371: Remove normalization in Pytorch Image Segmentation example
Posted by GitBox <gi...@apache.org>.
yeandy commented on PR #22371:
URL: https://github.com/apache/beam/pull/22371#issuecomment-1199770181
Failures are unrelate. Local gradle test passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on pull request #22371: Remove normalization in Pytorch Image Segmentation example
Posted by GitBox <gi...@apache.org>.
AnandInguva commented on PR #22371:
URL: https://github.com/apache/beam/pull/22371#issuecomment-1199874353
Run Python 3.7 PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] yeandy commented on pull request #22371: Remove normalization in Pytorch Image Segmentation example
Posted by GitBox <gi...@apache.org>.
yeandy commented on PR #22371:
URL: https://github.com/apache/beam/pull/22371#issuecomment-1198103714
Run Python 3.9 PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] yeandy commented on pull request #22371: Remove normalization in Pytorch Image Segmentation example
Posted by GitBox <gi...@apache.org>.
yeandy commented on PR #22371:
URL: https://github.com/apache/beam/pull/22371#issuecomment-1198176158
Run Python 3.9 PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] yeandy commented on pull request #22371: Remove normalization in Pytorch Image Segmentation example
Posted by GitBox <gi...@apache.org>.
yeandy commented on PR #22371:
URL: https://github.com/apache/beam/pull/22371#issuecomment-1198103524
Run Python 3.7 PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] yeandy commented on a diff in pull request #22371: Remove normalization in Pytorch Image Segmentation example
Posted by GitBox <gi...@apache.org>.
yeandy commented on code in PR #22371:
URL: https://github.com/apache/beam/pull/22371#discussion_r932249640
##########
sdks/python/apache_beam/examples/inference/pytorch_image_segmentation.py:
##########
@@ -147,12 +147,9 @@ def preprocess_image(data: Image.Image) -> torch.Tensor:
image_size = (224, 224)
# Pre-trained PyTorch models expect input images normalized with the
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22371: Remove normalization in Pytorch Image Segmentation example
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22371:
URL: https://github.com/apache/beam/pull/22371#issuecomment-1190632671
Ok - I'll remind @yeandy after tests pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] yeandy commented on pull request #22371: Remove normalization in Pytorch Image Segmentation example
Posted by GitBox <gi...@apache.org>.
yeandy commented on PR #22371:
URL: https://github.com/apache/beam/pull/22371#issuecomment-1190630925
Run Python 3.7 PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] yeandy commented on pull request #22371: Remove normalization in Pytorch Image Segmentation example
Posted by GitBox <gi...@apache.org>.
yeandy commented on PR #22371:
URL: https://github.com/apache/beam/pull/22371#issuecomment-1198175959
Run Python 3.7 PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] yeandy commented on pull request #22371: Remove normalization in Pytorch Image Segmentation example
Posted by GitBox <gi...@apache.org>.
yeandy commented on PR #22371:
URL: https://github.com/apache/beam/pull/22371#issuecomment-1198076402
R: @AnandInguva
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on a diff in pull request #22371: Remove normalization in Pytorch Image Segmentation example
Posted by GitBox <gi...@apache.org>.
AnandInguva commented on code in PR #22371:
URL: https://github.com/apache/beam/pull/22371#discussion_r932245733
##########
sdks/python/apache_beam/examples/inference/pytorch_image_segmentation.py:
##########
@@ -147,12 +147,9 @@ def preprocess_image(data: Image.Image) -> torch.Tensor:
image_size = (224, 224)
# Pre-trained PyTorch models expect input images normalized with the
Review Comment:
Can we remove these comments as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22371: Remove normalization in Pytorch Image Segmentation example
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22371:
URL: https://github.com/apache/beam/pull/22371#issuecomment-1198061372
Reminder, please take a look at this pr: @pabloem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] yeandy commented on pull request #22371: Remove normalization in Pytorch Image Segmentation example
Posted by GitBox <gi...@apache.org>.
yeandy commented on PR #22371:
URL: https://github.com/apache/beam/pull/22371#issuecomment-1190631665
remind me after tests pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22371: Remove normalization in Pytorch Image Segmentation example
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22371:
URL: https://github.com/apache/beam/pull/22371#issuecomment-1190732878
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] yeandy commented on pull request #22371: Remove normalization in Pytorch Image Segmentation example
Posted by GitBox <gi...@apache.org>.
yeandy commented on PR #22371:
URL: https://github.com/apache/beam/pull/22371#issuecomment-1202980593
Tests pass @TheNeuralBit @tvalentyn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] yeandy commented on pull request #22371: Remove normalization in Pytorch Image Segmentation example
Posted by GitBox <gi...@apache.org>.
yeandy commented on PR #22371:
URL: https://github.com/apache/beam/pull/22371#issuecomment-1190631238
Run Python 3.9 PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #22371: Remove normalization in Pytorch Image Segmentation example
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #22371:
URL: https://github.com/apache/beam/pull/22371#issuecomment-1190644064
# [Codecov](https://codecov.io/gh/apache/beam/pull/22371?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22371](https://codecov.io/gh/apache/beam/pull/22371?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e84addb) into [master](https://codecov.io/gh/apache/beam/commit/4821e035c148df1ed7eb9e7054e47fe2a7003a1f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4821e03) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #22371 +/- ##
==========================================
- Coverage 74.17% 74.16% -0.01%
==========================================
Files 706 706
Lines 93190 93189 -1
==========================================
- Hits 69121 69115 -6
- Misses 22801 22806 +5
Partials 1268 1268
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `83.53% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/22371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...m/examples/inference/pytorch\_image\_segmentation.py](https://codecov.io/gh/apache/beam/pull/22371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvaW5mZXJlbmNlL3B5dG9yY2hfaW1hZ2Vfc2VnbWVudGF0aW9uLnB5) | `0.00% <ø> (ø)` | |
| [sdks/python/apache\_beam/transforms/combiners.py](https://codecov.io/gh/apache/beam/pull/22371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9jb21iaW5lcnMucHk=) | `93.05% <0.00%> (-0.39%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/22371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.42% <0.00%> (-0.25%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/22371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `88.94% <0.00%> (-0.16%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/util.py](https://codecov.io/gh/apache/beam/pull/22371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy91dGlsLnB5) | `96.06% <0.00%> (-0.16%)` | :arrow_down: |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] yeandy commented on pull request #22371: Remove normalization in Pytorch Image Segmentation example
Posted by GitBox <gi...@apache.org>.
yeandy commented on PR #22371:
URL: https://github.com/apache/beam/pull/22371#issuecomment-1201511673
Run Python 3.7 PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on pull request #22371: Remove normalization in Pytorch Image Segmentation example
Posted by GitBox <gi...@apache.org>.
AnandInguva commented on PR #22371:
URL: https://github.com/apache/beam/pull/22371#issuecomment-1199874118
One of the test is fixed recently. Let's rerun the post commits again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22371: Remove normalization in Pytorch Image Segmentation example
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22371:
URL: https://github.com/apache/beam/pull/22371#issuecomment-1190703712
All checks have passed: @yeandy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] yeandy commented on pull request #22371: Remove normalization in Pytorch Image Segmentation example
Posted by GitBox <gi...@apache.org>.
yeandy commented on PR #22371:
URL: https://github.com/apache/beam/pull/22371#issuecomment-1199857217
R: @TheNeuralBit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on pull request #22371: Remove normalization in Pytorch Image Segmentation example
Posted by GitBox <gi...@apache.org>.
AnandInguva commented on PR #22371:
URL: https://github.com/apache/beam/pull/22371#issuecomment-1199874457
Run Python 3.9 PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] yeandy commented on pull request #22371: Remove normalization in Pytorch Image Segmentation example
Posted by GitBox <gi...@apache.org>.
yeandy commented on PR #22371:
URL: https://github.com/apache/beam/pull/22371#issuecomment-1201511758
Run Python 3.9 PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #22371: Remove normalization in Pytorch Image Segmentation example
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on PR #22371:
URL: https://github.com/apache/beam/pull/22371#issuecomment-1202983726
Thanks @yeandy!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit merged pull request #22371: Remove normalization in Pytorch Image Segmentation example
Posted by GitBox <gi...@apache.org>.
TheNeuralBit merged PR #22371:
URL: https://github.com/apache/beam/pull/22371
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org