You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/02/19 14:08:40 UTC

[GitHub] [ignite] anton-vinogradov commented on a change in pull request #8676: IGNITE-13970 ThinkClient service, application, simple test

anton-vinogradov commented on a change in pull request #8676:
URL: https://github.com/apache/ignite/pull/8676#discussion_r579210739



##########
File path: modules/ducktests/src/main/java/org/apache/ignite/internal/ducktest/tests/thin_client_test/ThinClientCachePut.java
##########
@@ -48,10 +48,10 @@ protected void run(JsonNode jsonNode) throws Exception {
         ClientCacheConfiguration cfg = new ClientCacheConfiguration();
         cfg.setName(cacheName);
 
-        System.out.println(">>> Cache requested [cacheName=" + cacheName + ']');
-        System.out.println(">>>                 [cacheMode=" + cacheMode + ']');
-        System.out.println(">>>                 [cacheAtomcityMode=" + cacheAtomcityMode + ']');
-        System.out.println(">>>                 [backups=" + backups + ']');
+        System.out.println(">>> Cache requested  [cacheName=" + cacheName + ']');

Review comment:
       We should never use System.out.println, use a logger instead.
   We should also avoid logging using some messages for a single event, this approach does not work in the case of concurrency.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org