You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/06/01 14:39:54 UTC

[GitHub] [superset] michael-s-molina opened a new pull request #14932: chore: Improves the native filters UI/UX - iteration 6

michael-s-molina opened a new pull request #14932:
URL: https://github.com/apache/superset/pull/14932


   ### SUMMARY
   Improves the native filters UI/UX - iteration 6.
   - Removes the sort option for the numeric range filter type
   - When the left panel vertical scroll is enabled, automatically scrolls down when adding a new item
   - Adds a TODO to rename the filter plugins
   - Fixes a bug where the parent filter disappeared after refreshing the dashboard
   - Sets a min-width for the left panel to deal with the case when we don't have any filter
   
   This work is part of the [Native dashboard filter project](https://github.com/apache/superset/projects/12)
   
   The items below will be handled in the next iterations:
   - Remove horizontal scroll when the column select is too wide
   - Unify the select components to use the AntD one. Currently, we have different selects with different themes and interactions.
   
   The iterations below are optional but recommended:
   - Split the FiltersConfigForm into smaller components to make it easier to read
   
   @villebro @rusackas @junlincc
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   https://user-images.githubusercontent.com/70410625/120341882-a8bd6200-c2cd-11eb-8679-543253fe1216.mp4
   
   https://user-images.githubusercontent.com/70410625/120341125-00a79900-c2cd-11eb-9291-70df122b268c.mp4
   
   ### TESTING INSTRUCTIONS
   Check the before and after videos to see all the problems and fixes.
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] villebro merged pull request #14932: chore: Improves the native filters UI/UX - iteration 6

Posted by GitBox <gi...@apache.org>.
villebro merged pull request #14932:
URL: https://github.com/apache/superset/pull/14932


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] kgabryje commented on pull request #14932: chore: Improves the native filters UI/UX - iteration 6

Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #14932:
URL: https://github.com/apache/superset/pull/14932#issuecomment-852942029


   @michael-s-molina Love those changes! 1 question - in the PR description it says `Opens the Advanced section if any of its options are checked`, but on the "after" video the advanced section is closed by default even though hierarchical filter checkbox is selected. Is that a bug or have I misunderstood the description?
   A suggestion for the next iteration - when I open the filters config modal, console gets flooded with warning messages from Antd Form (see screenshot). If it's easy to fix, it'd be great to get rid of those warning 🙂 
   ![image](https://user-images.githubusercontent.com/15073128/120471339-e0e3a400-c3a4-11eb-9ea6-c014cd0d00ab.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] junlincc commented on pull request #14932: chore: Improves the native filters UI/UX - iteration 6

Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #14932:
URL: https://github.com/apache/superset/pull/14932#issuecomment-852446738


   <img width="861" alt="Screen Shot 2021-06-01 at 11 18 29 AM" src="https://user-images.githubusercontent.com/67837651/120390688-e1b40180-c2e2-11eb-825c-45b29a6f11fc.png">
   Thank you @michael-s-molina, can we squeeze one change into this PR? after user remove all filters, the filter bar is narrowed. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] michael-s-molina commented on pull request #14932: chore: Improves the native filters UI/UX - iteration 6

Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #14932:
URL: https://github.com/apache/superset/pull/14932#issuecomment-852947189


   > @michael-s-molina Love those changes! 1 question - in the PR description it says `Opens the Advanced section if any of its options are checked`, but on the "after" video the advanced section is closed by default even though hierarchical filter checkbox is selected. Is that a bug or have I misunderstood the description?
   > A suggestion for the next iteration - when I open the filters config modal, console gets flooded with warning messages from Antd Form (see screenshot). If it's easy to fix, it'd be great to get rid of those warning 🙂
   > ![image](https://user-images.githubusercontent.com/15073128/120471339-e0e3a400-c3a4-11eb-9ea6-c014cd0d00ab.png)
   
   @kgabryje I added the `Opens the Advanced section if any of its options are checked` after recording the video 🤣 . I was going to add it in iteration 7 but since 6 was still opened I decided to increment it. Sorry about that. 
   
   I notice all these warnings too. I'm planning to fix this in the following optional iteration:
   > Split the FiltersConfigForm into smaller components to make it easier to read
   
   In fact, I'll change the PR description to make it more clear about that.
   > Split the FiltersConfigForm into smaller components to make it easier to read and remove react warnings


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #14932: chore: Improves the native filters UI/UX - iteration 6

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14932:
URL: https://github.com/apache/superset/pull/14932#issuecomment-852197189


   # [Codecov](https://codecov.io/gh/apache/superset/pull/14932?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#14932](https://codecov.io/gh/apache/superset/pull/14932?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e899be6) into [master](https://codecov.io/gh/apache/superset/commit/66282c331363887c0da486bc68976a6c350e8645?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (66282c3) will **increase** coverage by `0.00%`.
   > The diff coverage is `61.53%`.
   
   > :exclamation: Current head e899be6 differs from pull request most recent head 6cd8bfb. Consider uploading reports for the commit 6cd8bfb to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/14932/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/14932?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #14932   +/-   ##
   =======================================
     Coverage   77.62%   77.63%           
   =======================================
     Files         963      963           
     Lines       49316    49326   +10     
     Branches     6228     6233    +5     
   =======================================
   + Hits        38284    38295   +11     
   + Misses      10833    10832    -1     
     Partials      199      199           
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `72.48% <61.53%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/14932?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/14932/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `69.83% <33.33%> (+0.66%)` | :arrow_up: |
   | [...ts/nativeFilters/FiltersConfigModal/FilterTabs.tsx](https://codecov.io/gh/apache/superset/pull/14932/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRhYnMudHN4) | `86.66% <100.00%> (+2.05%)` | :arrow_up: |
   | [...eFilters/FiltersConfigModal/FiltersConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/14932/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdNb2RhbC50c3g=) | `95.29% <100.00%> (+0.11%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14932?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14932?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [66282c3...6cd8bfb](https://codecov.io/gh/apache/superset/pull/14932?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #14932: chore: Improves the native filters UI/UX - iteration 6

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14932:
URL: https://github.com/apache/superset/pull/14932#issuecomment-852197189


   # [Codecov](https://codecov.io/gh/apache/superset/pull/14932?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#14932](https://codecov.io/gh/apache/superset/pull/14932?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6cd8bfb) into [master](https://codecov.io/gh/apache/superset/commit/66282c331363887c0da486bc68976a6c350e8645?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (66282c3) will **decrease** coverage by `0.00%`.
   > The diff coverage is `73.46%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/14932/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/14932?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #14932      +/-   ##
   ==========================================
   - Coverage   77.62%   77.62%   -0.01%     
   ==========================================
     Files         963      963              
     Lines       49316    49345      +29     
     Branches     6228     6238      +10     
   ==========================================
   + Hits        38284    38306      +22     
   - Misses      10833    10840       +7     
     Partials      199      199              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `72.47% <73.46%> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/14932?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/14932/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `70.58% <61.76%> (+1.42%)` | :arrow_up: |
   | [...ts/nativeFilters/FiltersConfigModal/FilterTabs.tsx](https://codecov.io/gh/apache/superset/pull/14932/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRhYnMudHN4) | `86.66% <100.00%> (+2.05%)` | :arrow_up: |
   | [...nfigModal/FiltersConfigForm/getControlItemsMap.tsx](https://codecov.io/gh/apache/superset/pull/14932/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL2dldENvbnRyb2xJdGVtc01hcC50c3g=) | `97.05% <100.00%> (ø)` | |
   | [...eFilters/FiltersConfigModal/FiltersConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/14932/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdNb2RhbC50c3g=) | `95.29% <100.00%> (+0.11%)` | :arrow_up: |
   | [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/14932/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `67.42% <0.00%> (-1.57%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14932?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14932?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [66282c3...6cd8bfb](https://codecov.io/gh/apache/superset/pull/14932?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] kgabryje commented on pull request #14932: chore: Improves the native filters UI/UX - iteration 6

Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #14932:
URL: https://github.com/apache/superset/pull/14932#issuecomment-852956290


   Got it, thanks! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] villebro commented on a change in pull request #14932: chore: Improves the native filters UI/UX - iteration 6

Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #14932:
URL: https://github.com/apache/superset/pull/14932#discussion_r643674284



##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
##########
@@ -423,6 +425,14 @@ const FiltersConfigForm = (
     ({ value }) => value === filterToEdit?.cascadeParentIds[0],
   );
 
+  const hasParentFilter = !!parentFilter;
+
+  const hasPreFilter =
+    !!filterToEdit?.adhoc_filters || !!filterToEdit?.time_range;
+
+  const hasSorting =
+    typeof filterToEdit?.controlValues?.sortAscending === 'boolean';

Review comment:
       Not important for iteration 6, but it could be a good idea to add TODOs here, to make it easier to formulate a plan for automating this based on control properties in the future.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] kgabryje edited a comment on pull request #14932: chore: Improves the native filters UI/UX - iteration 6

Posted by GitBox <gi...@apache.org>.
kgabryje edited a comment on pull request #14932:
URL: https://github.com/apache/superset/pull/14932#issuecomment-852942029


   @michael-s-molina Love those changes! 1 question - in the PR description it says `Opens the Advanced section if any of its options are checked`, but on the "after" video the advanced section is closed by default even though hierarchical filter checkbox is selected. Is that a bug or have I misunderstood the description?
   A suggestion for the next iteration - when I open the filters config modal, console gets flooded with warning messages from Antd Form (see screenshot). If it's easy to fix, it'd be great to get rid of those warnings 🙂 
   ![image](https://user-images.githubusercontent.com/15073128/120471339-e0e3a400-c3a4-11eb-9ea6-c014cd0d00ab.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #14932: chore: Improves the native filters UI/UX - iteration 6

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14932:
URL: https://github.com/apache/superset/pull/14932#issuecomment-852197189


   # [Codecov](https://codecov.io/gh/apache/superset/pull/14932?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#14932](https://codecov.io/gh/apache/superset/pull/14932?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e899be6) into [master](https://codecov.io/gh/apache/superset/commit/66282c331363887c0da486bc68976a6c350e8645?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (66282c3) will **increase** coverage by `0.00%`.
   > The diff coverage is `61.53%`.
   
   > :exclamation: Current head e899be6 differs from pull request most recent head 38bfb59. Consider uploading reports for the commit 38bfb59 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/14932/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/14932?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #14932   +/-   ##
   =======================================
     Coverage   77.62%   77.63%           
   =======================================
     Files         963      963           
     Lines       49316    49326   +10     
     Branches     6228     6233    +5     
   =======================================
   + Hits        38284    38295   +11     
   + Misses      10833    10832    -1     
     Partials      199      199           
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `72.48% <61.53%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/14932?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/14932/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `69.83% <33.33%> (+0.66%)` | :arrow_up: |
   | [...ts/nativeFilters/FiltersConfigModal/FilterTabs.tsx](https://codecov.io/gh/apache/superset/pull/14932/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRhYnMudHN4) | `86.66% <100.00%> (+2.05%)` | :arrow_up: |
   | [...eFilters/FiltersConfigModal/FiltersConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/14932/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdNb2RhbC50c3g=) | `95.29% <100.00%> (+0.11%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14932?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14932?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [66282c3...38bfb59](https://codecov.io/gh/apache/superset/pull/14932?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] junlincc removed a comment on pull request #14932: chore: Improves the native filters UI/UX - iteration 6

Posted by GitBox <gi...@apache.org>.
junlincc removed a comment on pull request #14932:
URL: https://github.com/apache/superset/pull/14932#issuecomment-852446738


   <img width="861" alt="Screen Shot 2021-06-01 at 11 18 29 AM" src="https://user-images.githubusercontent.com/67837651/120390688-e1b40180-c2e2-11eb-825c-45b29a6f11fc.png">
   Thank you @michael-s-molina, can we squeeze one change into this PR? after user remove all filters, the filter bar is narrowed. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] commented on pull request #14932: chore: Improves the native filters UI/UX - iteration 6

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #14932:
URL: https://github.com/apache/superset/pull/14932#issuecomment-852197189


   # [Codecov](https://codecov.io/gh/apache/superset/pull/14932?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#14932](https://codecov.io/gh/apache/superset/pull/14932?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e899be6) into [master](https://codecov.io/gh/apache/superset/commit/66282c331363887c0da486bc68976a6c350e8645?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (66282c3) will **increase** coverage by `0.00%`.
   > The diff coverage is `61.53%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/14932/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/14932?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #14932   +/-   ##
   =======================================
     Coverage   77.62%   77.63%           
   =======================================
     Files         963      963           
     Lines       49316    49326   +10     
     Branches     6228     6233    +5     
   =======================================
   + Hits        38284    38295   +11     
   + Misses      10833    10832    -1     
     Partials      199      199           
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `72.48% <61.53%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/14932?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/14932/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `69.83% <33.33%> (+0.66%)` | :arrow_up: |
   | [...ts/nativeFilters/FiltersConfigModal/FilterTabs.tsx](https://codecov.io/gh/apache/superset/pull/14932/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlclRhYnMudHN4) | `86.66% <100.00%> (+2.05%)` | :arrow_up: |
   | [...eFilters/FiltersConfigModal/FiltersConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/14932/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdNb2RhbC50c3g=) | `95.29% <100.00%> (+0.11%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14932?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14932?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [66282c3...e899be6](https://codecov.io/gh/apache/superset/pull/14932?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org