You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/03/04 07:43:06 UTC

[GitHub] [iotdb] samperson1997 commented on a change in pull request #2771: Change the default max JVM heap size from 8GB to 64GB

samperson1997 commented on a change in pull request #2771:
URL: https://github.com/apache/iotdb/pull/2771#discussion_r587227022



##########
File path: server/src/assembly/resources/conf/iotdb-env.sh
##########
@@ -66,19 +66,19 @@ calculate_heap_sizes()
     fi
 
     # set max heap size based on the following
-    # max(min(1/2 ram, 1024MB), min(1/4 ram, 8GB))
+    # max(min(1/2 ram, 1024MB), min(1/4 ram, 64GB))
     # calculate 1/2 ram and cap to 1024MB

Review comment:
       Should this be changed?
   ```suggestion
       # calculate 1/2 ram and cap to 8192MB
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org