[jira] [Commented] (FLINK-2882) Improve performance of string conversions

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-2882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15057957#comment-15057957 ] 

ASF GitHub Bot commented on FLINK-2882:
---------------------------------------

GitHub user greghogan opened a pull request:

    https://github.com/apache/flink/pull/1455

    [FLINK-2882] [core] Improve performance of string conversions

    Memoize string representations of AbstractID.
    
    Use lookup table for byte-to-hex conversion in StringUtils.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/greghogan/flink 2882_improve_performance_of_string_conversions

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1455.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1455
    
----
commit e23322855f94245783d7f0a5accb1558d2816152
Author: Greg Hogan <co...@greghogan.com>
Date:   2015-12-14T19:47:33Z

    [FLINK-2882] [core] Improve performance of string conversions
    
    Memoize string representations of AbstractID.
    
    Use lookup table for byte-to-hex conversion in StringUtils.

----


> Improve performance of string conversions
> -----------------------------------------
>
>                 Key: FLINK-2882
>                 URL: https://issues.apache.org/jira/browse/FLINK-2882
>             Project: Flink
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.10.0
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>
> {{AbstractID.toString()}} and {{AbstractID.toShortString()}} call {{StringUtils.byteToHexString(...)}} which uses a StringBuilder to convert from binary to hex. This is a hotspot when scaling the number of workers.
> While testing on my single node with parallelism=512 jvisualvm reports 600,000 calls taking 13.4 seconds. Improving {{StringUtils.byteToHexString(...)}} reduces the time to 1.3 seconds. Additionally memoizing the string values in {{AbstractID}} reduce the time to 350 ms and the number of calls to {{StringUtils.byteToHexString(...)}} to ~1000.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)