You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/01/11 05:40:41 UTC
[GitHub] [kylin] wangxiaojing123 opened a new pull request #1050: KYLIN-4333
Fix Build Server OOM
wangxiaojing123 opened a new pull request #1050: KYLIN-4333 Fix Build Server OOM
URL: https://github.com/apache/kylin/pull/1050
- issue link :https://issues.apache.org/jira/browse/KYLIN-4333
- Internalthreadlocal is not suitable for creating a large number of instances . Otherwise, memory leakage will occur, leading to frequent full GC and even OOM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] nichunen merged pull request #1050: KYLIN-4333 Fix Build
Server OOM
Posted by GitBox <gi...@apache.org>.
nichunen merged pull request #1050: KYLIN-4333 Fix Build Server OOM
URL: https://github.com/apache/kylin/pull/1050
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io commented on issue #1050: KYLIN-4333 Fix Build
Server OOM
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1050: KYLIN-4333 Fix Build Server OOM
URL: https://github.com/apache/kylin/pull/1050#issuecomment-573286686
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1050?src=pr&el=h1) Report
> Merging [#1050](https://codecov.io/gh/apache/kylin/pull/1050?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/37770217b2a9d7a62a40acae74fe77ea1d170b2a?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `71.42%`.
[](https://codecov.io/gh/apache/kylin/pull/1050?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1050 +/- ##
============================================
- Coverage 25% 24.99% -0.02%
+ Complexity 6180 6178 -2
============================================
Files 1438 1438
Lines 87669 87669
Branches 12256 12256
============================================
- Hits 21926 21916 -10
- Misses 63593 63600 +7
- Partials 2150 2153 +3
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1050?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kylin/common/metrics/metrics2/CodahaleMetrics.java](https://codecov.io/gh/apache/kylin/pull/1050/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9tZXRyaWNzL21ldHJpY3MyL0NvZGFoYWxlTWV0cmljcy5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...apache/kylin/common/persistence/ResourceStore.java](https://codecov.io/gh/apache/kylin/pull/1050/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9wZXJzaXN0ZW5jZS9SZXNvdXJjZVN0b3JlLmphdmE=) | `70.25% <100%> (ø)` | `63 <0> (ø)` | :arrow_down: |
| [...ache/kylin/measure/topn/DoubleDeltaSerializer.java](https://codecov.io/gh/apache/kylin/pull/1050/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS90b3BuL0RvdWJsZURlbHRhU2VyaWFsaXplci5qYXZh) | `90.62% <100%> (ø)` | `23 <0> (ø)` | :arrow_down: |
| [...kylin/measure/percentile/PercentileSerializer.java](https://codecov.io/gh/apache/kylin/pull/1050/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9wZXJjZW50aWxlL1BlcmNlbnRpbGVTZXJpYWxpemVyLmphdmE=) | `75% <100%> (ø)` | `5 <1> (ø)` | :arrow_down: |
| [...he/kylin/metadata/datatype/DataTypeSerializer.java](https://codecov.io/gh/apache/kylin/pull/1050/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvZGF0YXR5cGUvRGF0YVR5cGVTZXJpYWxpemVyLmphdmE=) | `57.5% <50%> (ø)` | `3 <0> (ø)` | :arrow_down: |
| [...che/kylin/stream/core/storage/CheckPointStore.java](https://codecov.io/gh/apache/kylin/pull/1050/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvQ2hlY2tQb2ludFN0b3JlLmphdmE=) | `63.63% <0%> (-3.04%)` | `21% <0%> (-1%)` | |
| [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/1050/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `63.84% <0%> (-2.31%)` | `0% <0%> (ø)` | |
| [.../kylin/common/threadlocal/InternalThreadLocal.java](https://codecov.io/gh/apache/kylin/pull/1050/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi90aHJlYWRsb2NhbC9JbnRlcm5hbFRocmVhZExvY2FsLmphdmE=) | `52.94% <0%> (-1.48%)` | `13% <0%> (-1%)` | |
| [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1050/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.3% <0%> (-0.92%)` | `7% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1050?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1050?src=pr&el=footer). Last update [3777021...d7720be](https://codecov.io/gh/apache/kylin/pull/1050?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] coveralls commented on issue #1050: KYLIN-4333 Fix Build
Server OOM
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1050: KYLIN-4333 Fix Build Server OOM
URL: https://github.com/apache/kylin/pull/1050#issuecomment-573286930
## Pull Request Test Coverage Report for [Build 5499](https://coveralls.io/builds/28042770)
* **5** of **7** **(71.43%)** changed or added relevant lines in **5** files are covered.
* **7** unchanged lines in **3** files lost coverage.
* Overall coverage increased (+**0.005%**) to **27.458%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [core-common/src/main/java/org/apache/kylin/common/metrics/metrics2/CodahaleMetrics.java](https://coveralls.io/builds/28042770/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fmetrics%2Fmetrics2%2FCodahaleMetrics.java#L78) | 0 | 1 | 0.0%
| [core-metadata/src/main/java/org/apache/kylin/metadata/datatype/DataTypeSerializer.java](https://coveralls.io/builds/28042770/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Fdatatype%2FDataTypeSerializer.java#L121) | 1 | 2 | 50.0%
<!-- | **Total:** | **5** | **7** | **71.43%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [core-common/src/main/java/org/apache/kylin/common/threadlocal/InternalThreadLocal.java](https://coveralls.io/builds/28042770/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fthreadlocal%2FInternalThreadLocal.java#L148) | 1 | 61.76% |
| [stream-core/src/main/java/org/apache/kylin/stream/core/storage/CheckPointStore.java](https://coveralls.io/builds/28042770/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2FCheckPointStore.java#L98) | 2 | 73.74% |
| [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/28042770/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L555) | 4 | 77.81% |
<!-- | **Total:** | **7** | | -->
| Totals | [](https://coveralls.io/builds/28042770) |
| :-- | --: |
| Change from base [Build 5496](https://coveralls.io/builds/27996604): | 0.005% |
| Covered Lines: | 24072 |
| Relevant Lines: | 87669 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services