[GitHub] [arrow] emkornfield commented on pull request #8330: [Rust] [Parquet] Add roundtrip Arrow -> Parquet tests for all supported Arrow DataTypes

[GitBox <gi...@apache.org>]

emkornfield commented on pull request #8330:
URL: https://github.com/apache/arrow/pull/8330#issuecomment-703034687


   > I am not sure the actual data arrays have to be the same -- what needs to be the same is the data rows where the null_bit is 0 (aka we should probably be checking only for non-null rows)
   
   Small nit I'm prettry sure  null_bit = 1 is actually where values should be compared.  (thinking of it as a validity bitmap instead of a null bitmap helps).  And yes I agree they should be compared separately, as there is generally no requirement on the values of null fields (generally, you'll want to initialize to some known values to avoid security issues).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org