[GitHub] [sling-org-apache-sling-testing-clients] dulvac commented on a change in pull request #28: SLING-11131 - Update Apache HTTP Client Dependency for CVE-2020-13956

[GitBox <gi...@apache.org>]

dulvac commented on a change in pull request #28:
URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/28#discussion_r801854492



##########
File path: src/test/java/org/apache/sling/testing/AbstractSlingClientGetUrlTest.java
##########
@@ -130,7 +130,7 @@ public void testGetUrlWithParam() throws ClientException {
         SlingClient c = new SlingClient(URI.create(serverUrl), "USER", "PWD");
         assertEquals("", URI.create(expectedUrl), c.getUrl(inputPath));
         assertEquals(URI.create(expectedUrl), c.getUrl(inputPath, null));
-        assertEquals(URI.create(expectedUrl + "?"), c.getUrl(inputPath, new ArrayList<NameValuePair>()));
+        assertEquals(URI.create(expectedUrl), c.getUrl(inputPath, new ArrayList<NameValuePair>()));

Review comment:
       I see... I think you have to update the package version, though




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org