You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/10/17 18:15:58 UTC
[jira] [Commented] (BEAM-756) Checkstyle suppression for
JavadocPackage not working on Windows
[ https://issues.apache.org/jira/browse/BEAM-756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15582981#comment-15582981 ]
ASF GitHub Bot commented on BEAM-756:
-------------------------------------
GitHub user tweise opened a pull request:
https://github.com/apache/incubator-beam/pull/1114
BEAM-756 fix JavadocPackage checkstyle suppression
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tweise/incubator-beam BEAM-756
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1114.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1114
----
commit ff07a1119d5113fb15683e53d6a4d1c8ddbad4e6
Author: Thomas Weise <th...@apache.org>
Date: 2016-10-17T18:14:08Z
BEAM-756 fix JavadocPackage checkstyle suppression
----
> Checkstyle suppression for JavadocPackage not working on Windows
> ----------------------------------------------------------------
>
> Key: BEAM-756
> URL: https://issues.apache.org/jira/browse/BEAM-756
> Project: Beam
> Issue Type: Bug
> Reporter: Thomas Weise
> Assignee: Thomas Weise
>
> Exclusions for test and other files don't consider '\' as separator. Hence checkstyle complains about missing package-info files.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)