You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildr.apache.org by "Félix Enrique Llorente Pastora (JIRA)" <ji...@apache.org> on 2011/09/14 12:03:08 UTC
[jira] [Created] (BUILDR-611) Buildr recompile java code even if
it's not needed
Buildr recompile java code even if it's not needed
--------------------------------------------------
Key: BUILDR-611
URL: https://issues.apache.org/jira/browse/BUILDR-611
Project: Buildr
Issue Type: Bug
Components: Compilers
Affects Versions: 1.4.6
Reporter: Félix Enrique Llorente Pastora
We have something like that in our buildfile
compile.from(FileList[
FooI/jsrc/**/*.java',
Bar/jsrc/']
.exclude('FooJava.java'))
Calling build task twice do two compilations.
buildr doesn't remove the ";" character from the package name in the compile_map
We did have to use the following patch to fix it:
--- lib/buildr/core/compile.rb 2011-09-14 11:55:23.377091000 +0200
+++ lib/buildr/core/compile.rb.org 2011-09-14 11:56:08.619013000 +0200
@@ -193,7 +193,7 @@
# try to extract package name from .java or .scala files
if ['.java', '.scala', '.groovy'].include? File.extname(source)
package = findFirst(source, /^\s*package\s+(\S+)\s*;?\s*$/)
- map[source] = package ? File.join(target, package[1].gsub('.', '/').gsub(';',''), File.basename(source).ext(target_ext)) : target
+ map[source] = package ? File.join(target, package[1].gsub('.', '/'), File.basename(source).ext(target_ext)) : target
elsif
map[source] = target
end
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (BUILDR-611) Buildr should not unnecessarily
recompile Java files explicitly added to compile.from
Posted by "Peter Donald (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Donald reopened BUILDR-611:
---------------------------------
Assignee: Peter Donald (was: Alex Boisvert)
> Buildr should not unnecessarily recompile Java files explicitly added to compile.from
> -------------------------------------------------------------------------------------
>
> Key: BUILDR-611
> URL: https://issues.apache.org/jira/browse/BUILDR-611
> Project: Buildr
> Issue Type: Bug
> Components: Compilers
> Affects Versions: 1.4.6
> Reporter: Félix Enrique Llorente Pastora
> Assignee: Peter Donald
> Fix For: 1.4.7
>
>
> We have something like that in our buildfile
> compile.from(FileList[
> FooI/jsrc/**/*.java',
> Bar/jsrc/']
> .exclude('FooJava.java'))
> Calling build task twice do two compilations.
> buildr doesn't remove the ";" character from the package name in the compile_map
> We did have to use the following patch to fix it:
> --- lib/buildr/core/compile.rb 2011-09-14 11:55:23.377091000 +0200
> +++ lib/buildr/core/compile.rb.org 2011-09-14 11:56:08.619013000 +0200
> @@ -193,7 +193,7 @@
> # try to extract package name from .java or .scala files
> if ['.java', '.scala', '.groovy'].include? File.extname(source)
> package = findFirst(source, /^\s*package\s+(\S+)\s*;?\s*$/)
> - map[source] = package ? File.join(target, package[1].gsub('.', '/').gsub(';',''), File.basename(source).ext(target_ext)) : target
> + map[source] = package ? File.join(target, package[1].gsub('.', '/'), File.basename(source).ext(target_ext)) : target
> elsif
> map[source] = target
> end
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (BUILDR-611) Buildr should not unnecessarily
recompile Java files explicitly added to compile.from
Posted by "Peter Donald (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Donald closed BUILDR-611.
-------------------------------
Resolution: Fixed
> Buildr should not unnecessarily recompile Java files explicitly added to compile.from
> -------------------------------------------------------------------------------------
>
> Key: BUILDR-611
> URL: https://issues.apache.org/jira/browse/BUILDR-611
> Project: Buildr
> Issue Type: Bug
> Components: Compilers
> Affects Versions: 1.4.6
> Reporter: Félix Enrique Llorente Pastora
> Assignee: Peter Donald
> Fix For: 1.4.7
>
>
> We have something like that in our buildfile
> compile.from(FileList[
> FooI/jsrc/**/*.java',
> Bar/jsrc/']
> .exclude('FooJava.java'))
> Calling build task twice do two compilations.
> buildr doesn't remove the ";" character from the package name in the compile_map
> We did have to use the following patch to fix it:
> --- lib/buildr/core/compile.rb 2011-09-14 11:55:23.377091000 +0200
> +++ lib/buildr/core/compile.rb.org 2011-09-14 11:56:08.619013000 +0200
> @@ -193,7 +193,7 @@
> # try to extract package name from .java or .scala files
> if ['.java', '.scala', '.groovy'].include? File.extname(source)
> package = findFirst(source, /^\s*package\s+(\S+)\s*;?\s*$/)
> - map[source] = package ? File.join(target, package[1].gsub('.', '/').gsub(';',''), File.basename(source).ext(target_ext)) : target
> + map[source] = package ? File.join(target, package[1].gsub('.', '/'), File.basename(source).ext(target_ext)) : target
> elsif
> map[source] = target
> end
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BUILDR-611) Buildr should not unnecessarily
recompile Java files explicitly added to compile.from
Posted by "Peter Donald (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Donald updated BUILDR-611:
--------------------------------
Comment: was deleted
(was: http://tuvantlp.com/
http://tuvantlp.com/
http://tuvantlp.com/
http://tuvantlp.com/
http://tuvantlp.com/
good!)
> Buildr should not unnecessarily recompile Java files explicitly added to compile.from
> -------------------------------------------------------------------------------------
>
> Key: BUILDR-611
> URL: https://issues.apache.org/jira/browse/BUILDR-611
> Project: Buildr
> Issue Type: Bug
> Components: Compilers
> Affects Versions: 1.4.6
> Reporter: Félix Enrique Llorente Pastora
> Assignee: Peter Donald
> Fix For: 1.4.7
>
>
> We have something like that in our buildfile
> compile.from(FileList[
> FooI/jsrc/**/*.java',
> Bar/jsrc/']
> .exclude('FooJava.java'))
> Calling build task twice do two compilations.
> buildr doesn't remove the ";" character from the package name in the compile_map
> We did have to use the following patch to fix it:
> --- lib/buildr/core/compile.rb 2011-09-14 11:55:23.377091000 +0200
> +++ lib/buildr/core/compile.rb.org 2011-09-14 11:56:08.619013000 +0200
> @@ -193,7 +193,7 @@
> # try to extract package name from .java or .scala files
> if ['.java', '.scala', '.groovy'].include? File.extname(source)
> package = findFirst(source, /^\s*package\s+(\S+)\s*;?\s*$/)
> - map[source] = package ? File.join(target, package[1].gsub('.', '/').gsub(';',''), File.basename(source).ext(target_ext)) : target
> + map[source] = package ? File.join(target, package[1].gsub('.', '/'), File.basename(source).ext(target_ext)) : target
> elsif
> map[source] = target
> end
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (BUILDR-611) Buildr recompile java code even if
it's not needed
Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Boisvert reassigned BUILDR-611:
------------------------------------
Assignee: Alex Boisvert
> Buildr recompile java code even if it's not needed
> --------------------------------------------------
>
> Key: BUILDR-611
> URL: https://issues.apache.org/jira/browse/BUILDR-611
> Project: Buildr
> Issue Type: Bug
> Components: Compilers
> Affects Versions: 1.4.6
> Reporter: Félix Enrique Llorente Pastora
> Assignee: Alex Boisvert
>
> We have something like that in our buildfile
> compile.from(FileList[
> FooI/jsrc/**/*.java',
> Bar/jsrc/']
> .exclude('FooJava.java'))
> Calling build task twice do two compilations.
> buildr doesn't remove the ";" character from the package name in the compile_map
> We did have to use the following patch to fix it:
> --- lib/buildr/core/compile.rb 2011-09-14 11:55:23.377091000 +0200
> +++ lib/buildr/core/compile.rb.org 2011-09-14 11:56:08.619013000 +0200
> @@ -193,7 +193,7 @@
> # try to extract package name from .java or .scala files
> if ['.java', '.scala', '.groovy'].include? File.extname(source)
> package = findFirst(source, /^\s*package\s+(\S+)\s*;?\s*$/)
> - map[source] = package ? File.join(target, package[1].gsub('.', '/').gsub(';',''), File.basename(source).ext(target_ext)) : target
> + map[source] = package ? File.join(target, package[1].gsub('.', '/'), File.basename(source).ext(target_ext)) : target
> elsif
> map[source] = target
> end
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (BUILDR-611) Buildr should not unnecessarily
recompile Java files explicitly added to compile.from
Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Boisvert resolved BUILDR-611.
----------------------------------
Resolution: Fixed
Fix Version/s: 1.4.7
Thanks for pinpointing the issue. I decided to tweak the regular expression instead of using gsub().
Fixed now.
boisvert@honeybrown:~/git/buildr$ git svn dcommit
M CHANGELOG
M lib/buildr/core/compile.rb
M spec/core/compile_spec.rb
Committed r1170605
r1170605 = ab4f08d8ca66935770ba4c24e667527e54bf820c (refs/remotes/origin/trunk)
> Buildr should not unnecessarily recompile Java files explicitly added to compile.from
> -------------------------------------------------------------------------------------
>
> Key: BUILDR-611
> URL: https://issues.apache.org/jira/browse/BUILDR-611
> Project: Buildr
> Issue Type: Bug
> Components: Compilers
> Affects Versions: 1.4.6
> Reporter: Félix Enrique Llorente Pastora
> Assignee: Alex Boisvert
> Fix For: 1.4.7
>
>
> We have something like that in our buildfile
> compile.from(FileList[
> FooI/jsrc/**/*.java',
> Bar/jsrc/']
> .exclude('FooJava.java'))
> Calling build task twice do two compilations.
> buildr doesn't remove the ";" character from the package name in the compile_map
> We did have to use the following patch to fix it:
> --- lib/buildr/core/compile.rb 2011-09-14 11:55:23.377091000 +0200
> +++ lib/buildr/core/compile.rb.org 2011-09-14 11:56:08.619013000 +0200
> @@ -193,7 +193,7 @@
> # try to extract package name from .java or .scala files
> if ['.java', '.scala', '.groovy'].include? File.extname(source)
> package = findFirst(source, /^\s*package\s+(\S+)\s*;?\s*$/)
> - map[source] = package ? File.join(target, package[1].gsub('.', '/').gsub(';',''), File.basename(source).ext(target_ext)) : target
> + map[source] = package ? File.join(target, package[1].gsub('.', '/'), File.basename(source).ext(target_ext)) : target
> elsif
> map[source] = target
> end
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BUILDR-611) Buildr should not unnecessarily
recompile Java files explicitly added to compile.from
Posted by "tuvantlp.com (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496162#comment-13496162 ]
tuvantlp.com commented on BUILDR-611:
-------------------------------------
http://tuvantlp.com/index.php/thanh-lap-doanh-nghiep.html
http://tuvantlp.com/index.php/thanh-lap-doanh-nghiep.html
http://tuvantlp.com/index.php/thanh-lap-doanh-nghiep.html
http://tuvantlp.com/index.php/thanh-lap-doanh-nghiep.html
thành lập doanh nghiêp trọn gói
thành lập doanh nghiệp
dịch vụ kế toán
sổ sách kế toán
thanh lap doanh nghiep
dich vu ke toan
kế toán thuế
kế toán tlp.com
tuvantlp.com
sổ sách kế toán
> Buildr should not unnecessarily recompile Java files explicitly added to compile.from
> -------------------------------------------------------------------------------------
>
> Key: BUILDR-611
> URL: https://issues.apache.org/jira/browse/BUILDR-611
> Project: Buildr
> Issue Type: Bug
> Components: Compilers
> Affects Versions: 1.4.6
> Reporter: Félix Enrique Llorente Pastora
> Assignee: Alex Boisvert
> Fix For: 1.4.7
>
>
> We have something like that in our buildfile
> compile.from(FileList[
> FooI/jsrc/**/*.java',
> Bar/jsrc/']
> .exclude('FooJava.java'))
> Calling build task twice do two compilations.
> buildr doesn't remove the ";" character from the package name in the compile_map
> We did have to use the following patch to fix it:
> --- lib/buildr/core/compile.rb 2011-09-14 11:55:23.377091000 +0200
> +++ lib/buildr/core/compile.rb.org 2011-09-14 11:56:08.619013000 +0200
> @@ -193,7 +193,7 @@
> # try to extract package name from .java or .scala files
> if ['.java', '.scala', '.groovy'].include? File.extname(source)
> package = findFirst(source, /^\s*package\s+(\S+)\s*;?\s*$/)
> - map[source] = package ? File.join(target, package[1].gsub('.', '/').gsub(';',''), File.basename(source).ext(target_ext)) : target
> + map[source] = package ? File.join(target, package[1].gsub('.', '/'), File.basename(source).ext(target_ext)) : target
> elsif
> map[source] = target
> end
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BUILDR-611) Buildr should not unnecessarily
recompile Java files explicitly added to compile.from
Posted by "Peter Donald (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Donald updated BUILDR-611:
--------------------------------
Comment: was deleted
(was: http://tuvantlp.com/index.php/thanh-lap-doanh-nghiep.html
http://tuvantlp.com/index.php/thanh-lap-doanh-nghiep.html
http://tuvantlp.com/index.php/thanh-lap-doanh-nghiep.html
http://tuvantlp.com/index.php/thanh-lap-doanh-nghiep.html
thành lập doanh nghiêp trọn gói
thành lập doanh nghiệp
dịch vụ kế toán
sổ sách kế toán
thanh lap doanh nghiep
dich vu ke toan
kế toán thuế
kế toán tlp.com
tuvantlp.com
sổ sách kế toán)
> Buildr should not unnecessarily recompile Java files explicitly added to compile.from
> -------------------------------------------------------------------------------------
>
> Key: BUILDR-611
> URL: https://issues.apache.org/jira/browse/BUILDR-611
> Project: Buildr
> Issue Type: Bug
> Components: Compilers
> Affects Versions: 1.4.6
> Reporter: Félix Enrique Llorente Pastora
> Assignee: Peter Donald
> Fix For: 1.4.7
>
>
> We have something like that in our buildfile
> compile.from(FileList[
> FooI/jsrc/**/*.java',
> Bar/jsrc/']
> .exclude('FooJava.java'))
> Calling build task twice do two compilations.
> buildr doesn't remove the ";" character from the package name in the compile_map
> We did have to use the following patch to fix it:
> --- lib/buildr/core/compile.rb 2011-09-14 11:55:23.377091000 +0200
> +++ lib/buildr/core/compile.rb.org 2011-09-14 11:56:08.619013000 +0200
> @@ -193,7 +193,7 @@
> # try to extract package name from .java or .scala files
> if ['.java', '.scala', '.groovy'].include? File.extname(source)
> package = findFirst(source, /^\s*package\s+(\S+)\s*;?\s*$/)
> - map[source] = package ? File.join(target, package[1].gsub('.', '/').gsub(';',''), File.basename(source).ext(target_ext)) : target
> + map[source] = package ? File.join(target, package[1].gsub('.', '/'), File.basename(source).ext(target_ext)) : target
> elsif
> map[source] = target
> end
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BUILDR-611) Buildr should not unnecessarily
recompile Java files explicitly added to compile.from
Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Boisvert updated BUILDR-611:
---------------------------------
Summary: Buildr should not unnecessarily recompile Java files explicitly added to compile.from (was: Buildr recompile java code even if it's not needed)
> Buildr should not unnecessarily recompile Java files explicitly added to compile.from
> -------------------------------------------------------------------------------------
>
> Key: BUILDR-611
> URL: https://issues.apache.org/jira/browse/BUILDR-611
> Project: Buildr
> Issue Type: Bug
> Components: Compilers
> Affects Versions: 1.4.6
> Reporter: Félix Enrique Llorente Pastora
> Assignee: Alex Boisvert
>
> We have something like that in our buildfile
> compile.from(FileList[
> FooI/jsrc/**/*.java',
> Bar/jsrc/']
> .exclude('FooJava.java'))
> Calling build task twice do two compilations.
> buildr doesn't remove the ";" character from the package name in the compile_map
> We did have to use the following patch to fix it:
> --- lib/buildr/core/compile.rb 2011-09-14 11:55:23.377091000 +0200
> +++ lib/buildr/core/compile.rb.org 2011-09-14 11:56:08.619013000 +0200
> @@ -193,7 +193,7 @@
> # try to extract package name from .java or .scala files
> if ['.java', '.scala', '.groovy'].include? File.extname(source)
> package = findFirst(source, /^\s*package\s+(\S+)\s*;?\s*$/)
> - map[source] = package ? File.join(target, package[1].gsub('.', '/').gsub(';',''), File.basename(source).ext(target_ext)) : target
> + map[source] = package ? File.join(target, package[1].gsub('.', '/'), File.basename(source).ext(target_ext)) : target
> elsif
> map[source] = target
> end
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BUILDR-611) Buildr should not unnecessarily
recompile Java files explicitly added to compile.from
Posted by "tuvantlp.com (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496163#comment-13496163 ]
tuvantlp.com commented on BUILDR-611:
-------------------------------------
http://tuvantlp.com/
http://tuvantlp.com/
http://tuvantlp.com/
http://tuvantlp.com/
http://tuvantlp.com/
good!
> Buildr should not unnecessarily recompile Java files explicitly added to compile.from
> -------------------------------------------------------------------------------------
>
> Key: BUILDR-611
> URL: https://issues.apache.org/jira/browse/BUILDR-611
> Project: Buildr
> Issue Type: Bug
> Components: Compilers
> Affects Versions: 1.4.6
> Reporter: Félix Enrique Llorente Pastora
> Assignee: Alex Boisvert
> Fix For: 1.4.7
>
>
> We have something like that in our buildfile
> compile.from(FileList[
> FooI/jsrc/**/*.java',
> Bar/jsrc/']
> .exclude('FooJava.java'))
> Calling build task twice do two compilations.
> buildr doesn't remove the ";" character from the package name in the compile_map
> We did have to use the following patch to fix it:
> --- lib/buildr/core/compile.rb 2011-09-14 11:55:23.377091000 +0200
> +++ lib/buildr/core/compile.rb.org 2011-09-14 11:56:08.619013000 +0200
> @@ -193,7 +193,7 @@
> # try to extract package name from .java or .scala files
> if ['.java', '.scala', '.groovy'].include? File.extname(source)
> package = findFirst(source, /^\s*package\s+(\S+)\s*;?\s*$/)
> - map[source] = package ? File.join(target, package[1].gsub('.', '/').gsub(';',''), File.basename(source).ext(target_ext)) : target
> + map[source] = package ? File.join(target, package[1].gsub('.', '/'), File.basename(source).ext(target_ext)) : target
> elsif
> map[source] = target
> end
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BUILDR-611) Buildr should not unnecessarily
recompile Java files explicitly added to compile.from
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104601#comment-13104601 ]
Hudson commented on BUILDR-611:
-------------------------------
Integrated in Buildr-ci-build #275 (See [https://builds.apache.org/job/Buildr-ci-build/275/])
BUILDR-611 Buildr should not unnecessarily recompile Java files explicitly added to compile.from
boisvert :
Files :
* /buildr/trunk/CHANGELOG
* /buildr/trunk/lib/buildr/core/compile.rb
* /buildr/trunk/spec/core/compile_spec.rb
> Buildr should not unnecessarily recompile Java files explicitly added to compile.from
> -------------------------------------------------------------------------------------
>
> Key: BUILDR-611
> URL: https://issues.apache.org/jira/browse/BUILDR-611
> Project: Buildr
> Issue Type: Bug
> Components: Compilers
> Affects Versions: 1.4.6
> Reporter: Félix Enrique Llorente Pastora
> Assignee: Alex Boisvert
> Fix For: 1.4.7
>
>
> We have something like that in our buildfile
> compile.from(FileList[
> FooI/jsrc/**/*.java',
> Bar/jsrc/']
> .exclude('FooJava.java'))
> Calling build task twice do two compilations.
> buildr doesn't remove the ";" character from the package name in the compile_map
> We did have to use the following patch to fix it:
> --- lib/buildr/core/compile.rb 2011-09-14 11:55:23.377091000 +0200
> +++ lib/buildr/core/compile.rb.org 2011-09-14 11:56:08.619013000 +0200
> @@ -193,7 +193,7 @@
> # try to extract package name from .java or .scala files
> if ['.java', '.scala', '.groovy'].include? File.extname(source)
> package = findFirst(source, /^\s*package\s+(\S+)\s*;?\s*$/)
> - map[source] = package ? File.join(target, package[1].gsub('.', '/').gsub(';',''), File.basename(source).ext(target_ext)) : target
> + map[source] = package ? File.join(target, package[1].gsub('.', '/'), File.basename(source).ext(target_ext)) : target
> elsif
> map[source] = target
> end
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira