You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "shuiqingliu (via GitHub)" <gi...@apache.org> on 2024/07/16 08:47:48 UTC
[PR] [INLONG-10409][Dashboard] Support installing agents by SSH key-based auth [inlong]
shuiqingliu opened a new pull request, #10636:
URL: https://github.com/apache/inlong/pull/10636
<!-- Specify the issue this pull request going to fix.
The following *XYZ* should be replaced by the actual [GitHub Issue](https://github.com/apache/inlong/issues) number)-->
Fixes #10409
### Motivation
Implement SSH key-based authentication when installing the agent via SSH. This PR will provide a dashboard UI that allows users to retrieve the SSH public key and then manually upload it to the agent node.
### Modifications
<!--Describe the modifications you've done.-->
* Identification Type Addition: Introduced identify type to distinguish between password and SSH key authentication methods.
* SSH Key Tips: Added tips to guide users on uploading the SSH authentication key when selecting the SSH key type.
* Test Connection Feature: Implemented a 'Test Connection' button, allowing users to verify the correctness of their configuration settings.
* Localization Enhancements: Enhanced descriptions for both Chinese (CN) and English (EN) localizations to improve user understanding and accessibility.
### Verifying this change
*(Please pick either of the following options)*
- [x] This change is already covered by existing tests, such as:
*(please describe tests)*
Successfully tested both SSH password type and SSH key type connections to the agent node. This verification confirms that the new identification types and the 'Test Connection' feature are functioning as expected.
### Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? (not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-10409][Dashboard] Support installing agents by SSH key-based auth [inlong]
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang commented on code in PR #10636:
URL: https://github.com/apache/inlong/pull/10636#discussion_r1679015747
##########
inlong-dashboard/src/ui/locales/cn.json:
##########
@@ -771,9 +771,12 @@
"pages.Clusters.Node.IsInstall": "安装方式",
"pages.Clusters.Node.ManualInstall": "手动安装",
"pages.Clusters.Node.SSHInstall": "SSH 安装",
+ "pages.Clusters.Node.IdentifyType": "认证方式",
"pages.Clusters.Node.Username": "SSH 用户名",
"pages.Clusters.Node.Password": "SSH 密码",
+ "pages.Clusters.Node.SSHKey": "SSH 密钥",
"pages.Clusters.Node.SSHPort": "SSH 端口",
+ "pages.Clusters.Node.SSHKeyHelper": "请将公钥上传至 agent 节点的 ~/.ssh/authorized_keys 文件中",
Review Comment:
```suggestion
"pages.Clusters.Node.SSHKeyHelper": "请将公钥上传至 Agent 节点的 ~/.ssh/authorized_keys 文件中",
```
##########
inlong-dashboard/src/ui/locales/en.json:
##########
@@ -771,9 +771,12 @@
"pages.Clusters.Node.IsInstall": "Installation",
"pages.Clusters.Node.ManualInstall": "Manual",
"pages.Clusters.Node.SSHInstall": "SSH",
+ "pages.Clusters.Node.IdentifyType": "Identify Type",
"pages.Clusters.Node.Username": "SSH Username",
+ "pages.Clusters.Node.SSHKey": "SSH Key",
"pages.Clusters.Node.Password": "SSH Password",
"pages.Clusters.Node.SSHPort": "SSH Port",
+ "pages.Clusters.Node.SSHKeyHelper": "Please upload the public key to the ~/.ssh/authorized_keys file of the agent node",
Review Comment:
```suggestion
"pages.Clusters.Node.SSHKeyHelper": "Please upload the public key to the ~/.ssh/authorized_keys file of the Agent node",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-10409][Dashboard] Support installing agents by SSH key-based auth [inlong]
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang merged PR #10636:
URL: https://github.com/apache/inlong/pull/10636
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-10409][Dashboard] Support installing agents by SSH key-based auth [inlong]
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang commented on PR #10636:
URL: https://github.com/apache/inlong/pull/10636#issuecomment-2230365840
@wohainilaodou PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org