[GitHub] [superset] ktmud edited a comment on pull request #12903: fix(explore): hide time section for datasets with no time column

[GitBox <gi...@apache.org>]

ktmud edited a comment on pull request #12903:
URL: https://github.com/apache/superset/pull/12903#issuecomment-772126582


   Hi @srinify , here are the answers to your questions:
   
   > * How does the flow work when a user edits the data model, is the option revealed again?
   
   Yes, the Time section will re-appear. However, users will need to check "IS TEMPORAL" in order to select the new time column added:
   
   <img width="917" alt="is-temporal" src="https://user-images.githubusercontent.com/335541/106682659-d8ef3100-6577-11eb-8c27-1bd541f9c231.png">
   
   > * Does this clash with dashboard filters at all? Not sure how it would but ya
   
   Dashboard filters are separate to this. They are unlikely to clash. The same logic of hiding for non-timeseries dataset does apply to the legacy `FilterBox` though.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org