You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu> on 2024/09/23 19:40:49 UTC
Change in asterixdb[goldfish]: [ASTERIXDB-3510][COMP] Incorrectly removing expressions from AND clau...
From Peeyush Gupta <pe...@couchbase.com>:
Attention is currently required from: Peeyush Gupta.
Hello Jenkins, Anon. E. Moose #1000171,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18909
to look at the new patch set (#2).
Change subject: [ASTERIXDB-3510][COMP] Incorrectly removing expressions from AND clause in column filters
......................................................................
[ASTERIXDB-3510][COMP] Incorrectly removing expressions from AND clause in column filters
- user model changes: no
- storage format changes: no
- interface changes: yes
Details:
While creating columnar filters we were removing expression from AND clause if they can not
be pushed down. However, this is not correct if AND is not at the root e.g., in case of
NOT(expr1 AND expr2 AND expr3) where expr3 can not be pushed down, we can not create a column
filter by just removing expr3 from the AND clause i.e., NOT(expr1 AND expr2) and checking it later.
Ext-ref: MB-63602
Change-Id: I797acdbb90bd28bbe2a07f654ca6f15f835db0d7
---
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/pushdown/processor/AbstractFilterPushdownProcessor.java
A asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/008/008.003.adm
A asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/008/008.005.adm
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/pushdown/processor/ColumnFilterPushdownProcessor.java
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/pushdown/processor/ColumnRangeFilterPushdownProcessor.java
A asterixdb/asterix-app/data/json/data-1000.json
M asterixdb/asterix-app/src/test/resources/runtimets/sqlpp_queries.xml
A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/column/filter/008/008.005.query.sqlpp
A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/column/filter/008/008.002.update.sqlpp
A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/column/filter/008/008.003.query.sqlpp
A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/column/filter/008/008.007.query.sqlpp
A asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/008/008.007.adm
A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/column/filter/008/008.004.query.sqlpp
A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/column/filter/008/008.001.ddl.sqlpp
A asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/008/008.006.adm
A asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/008/008.004.adm
A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/column/filter/008/008.006.query.sqlpp
17 files changed, 9,229 insertions(+), 15 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/09/18909/2
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18909
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: goldfish
Gerrit-Change-Id: I797acdbb90bd28bbe2a07f654ca6f15f835db0d7
Gerrit-Change-Number: 18909
Gerrit-PatchSet: 2
Gerrit-Owner: Peeyush Gupta <pe...@couchbase.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-CC: Ali Alsuliman <al...@gmail.com>
Gerrit-CC: Murtadha Hubail <mh...@apache.org>
Gerrit-Attention: Peeyush Gupta <pe...@couchbase.com>
Gerrit-MessageType: newpatchset