You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/12/28 22:01:58 UTC
[jira] [Commented] (BEAM-1226) Use well known coder types in Python
for KV, Iterable, WindowedValue, GlobalWindow, and LengthPrefix
[ https://issues.apache.org/jira/browse/BEAM-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15783795#comment-15783795 ]
ASF GitHub Bot commented on BEAM-1226:
--------------------------------------
GitHub user lukecwik opened a pull request:
https://github.com/apache/beam/pull/1709
[BEAM-1226] Add support for well known coder types to Apache Beam Python SDK
This uses specific cloud object representations for the following types:
kind:pair (TupleCoder with two components, previously pickled)
kind:stream (IterableCoder with a single component, previously ignored)
kind:global_window (GlobalWindowCoder, previously SingletonCoder)
kind:length_prefix (A new type of coder which always encodes the length of the value type as a prefix, has a single component)
kind:windowed_value (A wrapper coder with two components (value coder and window coder))
This also drops the ability to configure the timestamp coder on WindowedValueCoder.
These changes are towards having a common binary representation for certain well known coders across multiple languages.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lukecwik/incubator-beam well_known_python_coders
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/1709.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1709
----
commit 6272e296c946311e28f3edc848eaa6caf794ef9d
Author: Luke Cwik <lc...@google.com>
Date: 2016-12-28T21:54:58Z
[BEAM-1226] Add support for well known coder types to Apache Beam python SDK
This uses specific cloud object representations for the following types:
kind:pair (TupleCoder with two components, previously pickled)
kind:stream (IterableCoder with a single component, previously ignored)
kind:global_window (GlobalWindowCoder, previously SingletonCoder)
kind:length_prefix (A new type of coder which always encodes the length of the value type as a prefix, has a single component)
kind:windowed_value (A wrapper coder with two components (value coder and window coder))
This also drops the ability to configure the timestamp coder on WindowedValueCoder.
These changes are towards having a common binary representation for certain well known coders across multiple languages.
----
> Use well known coder types in Python for KV, Iterable, WindowedValue, GlobalWindow, and LengthPrefix
> ----------------------------------------------------------------------------------------------------
>
> Key: BEAM-1226
> URL: https://issues.apache.org/jira/browse/BEAM-1226
> Project: Beam
> Issue Type: Improvement
> Components: beam-model-fn-api
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: Minor
>
> Add support for using kind for well known coder types in Apache Beam for Python
> The following specific cloud object representations for the following types should exist:
> kind:pair (TupleCoder with two components)
> kind:stream (IterableCoder with a single component)
> kind:global_window (GlobalWindowCoder)
> kind:length_prefix (A new type of coder which always encodes the length of the value type as a prefix, has a single component)
> kind:windowed_value (A wrapper coder with two components (value coder and window coder))
> These changes are towards having a common binary representation for certain well known coders across multiple languages.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)